-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Replace instances of "query" with "statement" #14680
[pkg/ottl] Replace instances of "query" with "statement" #14680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3f90bc2
to
cf15995
Compare
Should the docu here be changed to statements as well? https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/processing.md#telemetry-query-language |
Description:
This replaces the remaining instances of "query" with "statement" between the OTTL and transform processor. For simplicity, I've made this a breaking change in both components. We could make the change more gradual by supporting both
queries
andstatements
, but that would require additional logic to process both and handle precedence, so it seems like a better move to take advantage of the alpha status of the transform processor here.Testing:
Unit tests have been updated and run, and the changes were run locally.
Documentation:
Updated relevant READMEs.