Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Replace instances of "query" with "statement" #14680

Merged

Conversation

evan-bradley
Copy link
Contributor

Description:

This replaces the remaining instances of "query" with "statement" between the OTTL and transform processor. For simplicity, I've made this a breaking change in both components. We could make the change more gradual by supporting both queries and statements, but that would require additional logic to process both and handle precedence, so it seems like a better move to take advantage of the alpha status of the transform processor here.

Testing:

Unit tests have been updated and run, and the changes were run locally.

Documentation:

Updated relevant READMEs.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking this

Copy link
Member

@kovrus kovrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evan-bradley evan-bradley force-pushed the ottl-query-to-statement branch from 3f90bc2 to cf15995 Compare October 4, 2022 15:32
@bogdandrutu bogdandrutu merged commit 8ad476c into open-telemetry:main Oct 5, 2022
@splunkenizer
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants