Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Correctly derive status for logs from 'level' #14571

Merged

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Sep 28, 2022

Description: Bug fix for recently added logs support in Datadog
When a log has level field, we want to use that for status rather than try to derive if from severityNumber .

Link to tracking Issue: #2651

Testing: Tested by deploying demo application.

Documentation: Documentation will be added in followup PR

@dineshg13 dineshg13 marked this pull request as ready for review September 28, 2022 17:44
@dineshg13 dineshg13 requested a review from a team September 28, 2022 17:44
@dineshg13 dineshg13 requested a review from mx-psi as a code owner September 28, 2022 17:44
@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 28, 2022
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but please update the PR title and description to something more descriptive (what bug are you fixing in particular?)

@dineshg13
Copy link
Member Author

updated the description

@mx-psi mx-psi changed the title [exporter/datadog] Bug fix for json logs [exporter/datadog] Correctly derive status for logs from 'level' Sep 28, 2022
@mx-psi mx-psi merged commit d80a720 into open-telemetry:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants