Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awsemfexporter] Fix regression in dimension roll up #14532

Merged
merged 5 commits into from
Sep 28, 2022
Merged

[exporter/awsemfexporter] Fix regression in dimension roll up #14532

merged 5 commits into from
Sep 28, 2022

Conversation

rapphil
Copy link
Contributor

@rapphil rapphil commented Sep 27, 2022 •
edited
Loading

Description: Fix regression that causes null dimensions

Caused by #13764

Link to tracking Issue: #14531

Testing:

Improved UTs that were not helpful before.

Documentation:

@rapphil rapphil requested a review from a team September 27, 2022 04:42
@rapphil rapphil requested a review from Aneurysm9 as a code owner September 27, 2022 04:42
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 27, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rapphil / name: Raphael Philipe Mendes da Silva (6e97bfeb3c264d7e5f39365d08f95fdfd48af5e1, f4c810eab86f0ddc9dfaea3f8372ec33917e7b42)

@rapphil rapphil closed this Sep 27, 2022
@rapphil rapphil deleted the rapphil-fix-regression-dimension-rollup branch September 27, 2022 04:49
@rapphil rapphil restored the rapphil-fix-regression-dimension-rollup branch September 27, 2022 04:49
@rapphil rapphil reopened this Sep 27, 2022
@bogdandrutu
Copy link
Member

Please rebase changes already merged are shown in your PR. Also make sure you pass the EasyCLA

@rapphil rapphil force-pushed the rapphil-fix-regression-dimension-rollup branch from cd91372 to f4c810e Compare September 27, 2022 04:58
@rapphil rapphil changed the title [exporter/awsemfexporter] Fix regression in dimension rollup [exporter/awsemfexporter] Fix regression in dimension roll up Sep 27, 2022
Aneurysm9
Aneurysm9 reviewed Sep 27, 2022
View reviewed changes
exporter/awsemfexporter/metric_translator_test.go Outdated Show resolved Hide resolved
exporter/awsemfexporter/util.go Outdated Show resolved Hide resolved
@Aneurysm9 Aneurysm9 linked an issue Sep 27, 2022 that may be closed by this pull request
awsemfexporter is producing dimensions with null value instead of empty dimension #14531
Closed
@rapphil rapphil force-pushed the rapphil-fix-regression-dimension-rollup branch from 1f25f6c to a325a24 Compare September 27, 2022 19:53
@rapphil rapphil requested review from bogdandrutu and removed request for dashpole, djaglowski, mx-psi and dmitryax September 27, 2022 21:21
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Sep 27, 2022
@bogdandrutu bogdandrutu merged commit 575c72b into open-telemetry:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees

@Aneurysm9 Aneurysm9

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

awsemfexporter is producing dimensions with null value instead of empty dimension
3 participants
@rapphil @bogdandrutu @Aneurysm9