Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/winperfcounters] Add counter name to ScrapeData errors #14450

Merged
merged 2 commits into from
Sep 28, 2022
Merged

[pkg/winperfcounters] Add counter name to ScrapeData errors #14450

merged 2 commits into from
Sep 28, 2022

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Add counter path to errors returned when scraping perfcounter data.

Link to tracking Issue: Resolves #14443

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review September 22, 2022 19:07
@BinaryFissionGames BinaryFissionGames requested a review from a team September 22, 2022 19:07
dashpole
dashpole approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@djaglowski djaglowski merged commit a473a33 into open-telemetry:main Sep 28, 2022
@djaglowski djaglowski deleted the winperfcounters-add-countername-to-error branch September 28, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@dashpole dashpole dashpole approved these changes

Assignees

@Aneurysm9 Aneurysm9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pkg/winperfcounters] Improve error when a performance counter fails to scrape
4 participants
@BinaryFissionGames @dashpole @djaglowski @Aneurysm9