Move sqlquery receiver logic out to a library for reuse #14321
Conversation
atoulme
force-pushed
the
move_sqlquery
branch
5 times, most recently
from
84ed7a9 to
730edbb
Compare
| @@ -0,0 +1,49 @@ | |||
| # SQL Query | |||
There was a problem hiding this comment.
This looks a documentation for sqlquery receiver. I'm not sure if is relevant enough to this package to keep it in sync with the receiver.
|
Please rebase |
atoulme
force-pushed
the
move_sqlquery
branch
from
07e463d to
6c23d8c
Compare
atoulme
force-pushed
the
move_sqlquery
branch
from
c954bc5 to
2498f41
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package sqlqueryreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver" | |||
| package sqlquery // import "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/sqlquery" | |||
There was a problem hiding this comment.
How confident are you that we need to move the receiver config to be part of this library? I feel like the config is a receiver-only thing, and the sqlquery API shouldn't know about it.
There was a problem hiding this comment.
I think I need to redo this work, based off what I learned from oracledb. This PR is not good enough.
|
As noted, this PR will get a redo once the #16044 PR is merged. Trying to not rush this. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
I'm just not sure this is a good idea anymore, if only because the sqlqueryreceiver has more dependencies to other DB drivers. Closing. |
Description:
Extract sqlquery receiver logic out to
pkg/sqlqueryso it may be reused across components.Link to tracking Issue:
#13547
Testing:
Same unit testing, just moving files.
Documentation:
Simple README.md.