Add Instana exporter implementation #13620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickeyma
force-pushed
the
feat/add-instana-exp-impl
branch
from
3bfde92 to
961e07c
Compare
jpkrohling
reviewed
Aug 25, 2022
hickeyma
force-pushed
the
feat/add-instana-exp-impl
branch
from
8a98a1f to
52dbeba
Compare
|
Thank you for the review and feedback @jpkrohling. I have updated your comments and it is ready for review again. |
hickeyma
force-pushed
the
feat/add-instana-exp-impl
branch
from
52dbeba to
11917ff
Compare
hickeyma
force-pushed
the
feat/add-instana-exp-impl
branch
from
11917ff to
24097f7
Compare
jpkrohling
reviewed
Aug 29, 2022
Signed-off-by: Martin Hickey <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Signed-off-by: Martin Hickey <[email protected]>
Review comments: - open-telemetry#13620 (review) Signed-off-by: Martin Hickey <[email protected]>
hickeyma
force-pushed
the
feat/add-instana-exp-impl
branch
from
24097f7 to
e02b360
Compare
Review comments: - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) - open-telemetry#13620 (comment) Signed-off-by: Martin Hickey <[email protected]>
|
Thanks for the review @jpkrohling. Updated and ready for review again. |
jpkrohling
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Hickey [email protected]
Co-authored-by: Martin Hickey [email protected]
Co-authored-by: Cedric Ziel [email protected]
Co-authored-by: Willian Carvalho [email protected]
Description:
This is the second of 3 PRs which adds the new component, Instana exporter. This PR
adds the exporter implementation.
Link to tracking Issue:
Partial #13395
Testing:
Unit Tests