Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fixed the "Getting In touch" URL #13533

Merged
merged 4 commits into from
Sep 6, 2022
Merged

[chore] Fixed the "Getting In touch" URL #13533

merged 4 commits into from
Sep 6, 2022

Conversation

MalaSundaramoorthy
Copy link
Contributor

@MalaSundaramoorthy MalaSundaramoorthy commented Aug 23, 2022 •
edited
Loading

Description:

Fixes #10467
Motivation: Update the "Getting In Touch" link which was pointing to abandoned link.

Link to tracking Issue: Issue : Getting In Touch" references disused resource #10467

**How it has been tested **

  • Identified Below URL is the working one for opentelemetry-collector-contrib for github main page

https://github.com/open-telemetry/opentelemetry-collector-contrib

  • Tested on browser

@MalaSundaramoorthy MalaSundaramoorthy requested review from a team and codeboten August 23, 2022 17:17
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 23, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: MalaSundaramoorthy (ec93a54)

@MalaSundaramoorthy MalaSundaramoorthy mentioned this pull request Aug 30, 2022
Closed
6 tasks
@MalaSundaramoorthy
Copy link
Contributor Author

@codeboten
This is my first time contribution. Help me to pass the above checks. Since my changes contributes to "README" file. Do I need to pass these checks?

jpkrohling
jpkrohling reviewed Aug 31, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@MalaSundaramoorthy MalaSundaramoorthy changed the title Fixed the "Getting In touch" URL [chore] Fixed the "Getting In touch" URL Sep 2, 2022
@MalaSundaramoorthy
Create fix-broken-link.yaml
db40c6f 
updating changelog
@MalaSundaramoorthy
Copy link
Contributor Author

@jpkrohling created a entry changelog in unreleased folder

@MalaSundaramoorthy MalaSundaramoorthy requested review from jpkrohling and removed request for codeboten September 6, 2022 14:32
@jpkrohling jpkrohling added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 6, 2022
@MalaSundaramoorthy
Delete fix-broken-link.yaml
06ab26e 
removed entry in changelog
@MalaSundaramoorthy
Copy link
Contributor Author

@jpkrohling please review and help me to pass the checks. Thanks.

@jpkrohling
Copy link
Member

I'll merge this on green.

@jpkrohling jpkrohling merged commit 0988c97 into open-telemetry:main Sep 6, 2022
@MalaSundaramoorthy
Copy link
Contributor Author

@jpkrohling Thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees

@bogdandrutu bogdandrutu

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Getting In Touch" references disused resource
3 participants
@MalaSundaramoorthy @jpkrohling @bogdandrutu