-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Elasticsearch receiver metrics #13446
Merged
djaglowski
merged 6 commits into
open-telemetry:main
from
davidji99:add-more-esreceiver-metrics-2
Aug 30, 2022
Merged
Add more Elasticsearch receiver metrics #13446
djaglowski
merged 6 commits into
open-telemetry:main
from
davidji99:add-more-esreceiver-metrics-2
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidji99
changed the title
Add more esreceiver metrics 2
Add more Elasticsearch receiver metrics
Aug 22, 2022
djaglowski
reviewed
Aug 22, 2022
Thank you for your reviews. I appreciate it. Could you take a look? I'd like feedback on the naming before I update the tests. Thank you! |
davidji99
force-pushed
the
add-more-esreceiver-metrics-2
branch
5 times, most recently
from
August 24, 2022 20:17
9760e07
to
1d0533d
Compare
Could you take a look again? Thank you. |
davidji99
force-pushed
the
add-more-esreceiver-metrics-2
branch
from
August 25, 2022 22:59
1d0533d
to
f58293a
Compare
- indexing_pressure, published_states, state_queue, ingest, script
davidji99
force-pushed
the
add-more-esreceiver-metrics-2
branch
from
August 29, 2022 01:44
f58293a
to
7e0ae59
Compare
Friendly bump when you get a chance. |
davidji99
force-pushed
the
add-more-esreceiver-metrics-2
branch
from
August 29, 2022 22:22
a48311d
to
99a4e61
Compare
Ready for review |
djaglowski
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13115
Description:
Adding more elasticsearch receiver metrics for indexing_pressure, published_states, state_queue, ingest, script.