Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Elasticsearch receiver metrics #13446

Merged

Conversation

davidji99
Copy link
Contributor

Fixes #13115

Description:

Adding more elasticsearch receiver metrics for indexing_pressure, published_states, state_queue, ingest, script.

@davidji99 davidji99 requested a review from a team August 22, 2022 02:33
@davidji99 davidji99 requested a review from djaglowski as a code owner August 22, 2022 02:33
@davidji99 davidji99 changed the title Add more esreceiver metrics 2 Add more Elasticsearch receiver metrics Aug 22, 2022
receiver/elasticsearchreceiver/internal/model/nodestats.go Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/metadata.yaml Outdated Show resolved Hide resolved
@davidji99
Copy link
Contributor Author

@djaglowski

Thank you for your reviews. I appreciate it. Could you take a look? I'd like feedback on the naming before I update the tests. Thank you!

@davidji99 davidji99 force-pushed the add-more-esreceiver-metrics-2 branch 5 times, most recently from 9760e07 to 1d0533d Compare August 24, 2022 20:17
@davidji99
Copy link
Contributor Author

@djaglowski

Could you take a look again? Thank you.

@davidji99 davidji99 force-pushed the add-more-esreceiver-metrics-2 branch from 1d0533d to f58293a Compare August 25, 2022 22:59
@davidji99 davidji99 force-pushed the add-more-esreceiver-metrics-2 branch from f58293a to 7e0ae59 Compare August 29, 2022 01:44
@davidji99
Copy link
Contributor Author

@djaglowski

Friendly bump when you get a chance.

@davidji99 davidji99 force-pushed the add-more-esreceiver-metrics-2 branch from a48311d to 99a4e61 Compare August 29, 2022 22:22
@davidji99
Copy link
Contributor Author

davidji99 commented Aug 30, 2022

Ready for review

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djaglowski djaglowski merged commit ed52a1f into open-telemetry:main Aug 30, 2022
@davidji99 davidji99 deleted the add-more-esreceiver-metrics-2 branch August 30, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/elasticsearchreceiver]: Add more metrics
3 participants