[project] Fix linting picking up local dir #13412

jsumners · 2022-08-18T12:46:05Z

Description:

While working on #13410 I encountered a linting error. When running make lint locally, the linter was failing for two reasons:

It wanted a license block added to a Go file in the local/ directory
It didn't like that a function was unused in the same Go file in the local/ directory

The .gitignore specifically excludes the local/ directory:

Line 1 in 2892f12

local/

We should not lint code in that directory.

Does this PR need a changelog yaml file?

dmitryax · 2022-08-20T05:07:55Z

@jsumners what do need to have in local directory causing such issues? Usually local should have only configs for local testing

jsumners · 2022-08-20T11:15:07Z

Does it matter? The directory is meant to be ignored. Regardless, I have a scratch file that contains arbitrary code.

github-actions · 2022-09-06T05:42:43Z

This PR was marked stale due to lack of activity. It will be closed in 14 days.

jsumners · 2022-09-06T12:03:07Z

Can we merge this?

jsumners · 2022-09-06T14:31:33Z

Thank you.

jsumners requested review from a team and jpkrohling August 18, 2022 12:46

github-actions bot assigned TylerHelmuth Aug 18, 2022

TylerHelmuth approved these changes Aug 18, 2022

View reviewed changes

TylerHelmuth added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 18, 2022

jsumners force-pushed the mezmo/tweak-lint branch 2 times, most recently from e6abeaa to cd4b277 Compare August 18, 2022 17:03

[project] Fix linting picking up local dir

a5a7c7d

jsumners force-pushed the mezmo/tweak-lint branch from cd4b277 to a5a7c7d Compare August 22, 2022 17:33

github-actions bot added the Stale label Sep 6, 2022

jpkrohling approved these changes Sep 6, 2022

View reviewed changes

jpkrohling merged commit d2490af into open-telemetry:main Sep 6, 2022

jsumners deleted the mezmo/tweak-lint branch September 6, 2022 14:31

Provide feedback