[pkg/stanza] Remove unused "host_identifier" #13396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
added
Skip Changelog
djaglowski
force-pushed
the
pkg-stanza-rmhostid
branch
from
6021881 to
dbe233b
Compare
djaglowski
changed the title
djaglowski
changed the title
djaglowski
force-pushed
the
pkg-stanza-rmhostid
branch
from
dbe233b to
9a20a29
Compare
|
Looks like this removes some exported functions and structs, do we need a Breaking Change changelog entry? |
This code was formerly used to detect metadata such as hostname, roughly equivalent in purpose to the resourcedetectionprocessor.
djaglowski
force-pushed
the
pkg-stanza-rmhostid
branch
from
9a20a29 to
980f4a5
Compare
|
I added a changelog entry. There's very little chance this affects anyone, but you're right that we should capture it just in case. |
TylerHelmuth
approved these changes
Aug 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was formerly used to detect metadata such as hostname,
roughly equivalent in purpose to the resourcedetectionprocessor.