[pkg/stanza] Fix bug where original severity text was not preserved #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting from entry.Entry to plog.Logs, the severity text was not copied over. Instead, it was automatically assigned based on the severity number. This change does two things: 1. If the severity text is not empty, it is preserved 2. If the severity text is empty, it is assigned based on the severity number. However, the values assigned were also incorrect, in that they did not match the case defined in the data model. Previously, a capitalized style (eg "Info") was used. Now, an all caps style is used. It is rare that severity number is specified while severity text is not, but the data model explicitly calls for this handling, so it is implemented as such.
|
@open-telemetry/collector-contrib-approvers, please take a look. |
dashpole
approved these changes
Aug 22, 2022
|
cc @damemi |
|
@dashpole I think we added a fix for a version of this issue downstream in GoogleCloudPlatform/opentelemetry-operations-go#446. There, we tried reverse-mapping the severity text if it was present to the matching severity number. I think we'll still need that fix though since it's mapping the otel text to a gcp number |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting from entry.Entry to plog.Logs, the severity text
was not copied over. Instead, it was automatically assigned based
on the severity number.
This change does two things:
number. However, the values assigned were also incorrect, in that they
did not match the case defined in the data model. Previously, a
capitalized style (eg "Info") was used. Now, an all caps style is used.
It is rare that severity number is specified while severity text is not,
but the data model explicitly calls for this handling, so it is implemented
as such.
Resolves #13263
Resolves #10278