[processor/k8sattributes] add CronJob name attribute #13214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
k8sattributes-cronjob
branch
from
44182fc to
4f0ba36
Compare
dmitryax
reviewed
Aug 11, 2022
povilasv
force-pushed
the
k8sattributes-cronjob
branch
2 times, most recently
from
d8fd00c to
880519c
Compare
|
@dmitryax thanks for review, it's ready for another round :) FYI I've looked up how K8s creates job names this is the code -> https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/cronjob/cronjob_controllerv2.go#L640-L642 Also, I've looked at an example CronJob and these are the patterns: CronJob Name: es-mgmt-snapshots |
povilasv
force-pushed
the
k8sattributes-cronjob
branch
from
880519c to
757afae
Compare
dmitryax
reviewed
Aug 12, 2022
Co-authored-by: Dmitrii Anoshin <[email protected]>
povilasv
force-pushed
the
k8sattributes-cronjob
branch
from
3da70bc to
d961913
Compare
dmitryax
approved these changes
Aug 17, 2022
dmitryax
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding support for discovering K8S CronJob name attribute
Link to tracking Issue:
Ref #141
Testing:
Documentation:
Updated go docs