Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/k8sattributes] add Job attributes #13116

Merged
merged 1 commit into from
Aug 9, 2022
Merged

[processor/k8sattributes] add Job attributes #13116

merged 1 commit into from
Aug 9, 2022

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Aug 9, 2022

Description:

Adding support for discovering K8S Job attributes

Link to tracking Issue:

Ref #141

Testing:

  • unit tests

Documentation:

Updated go docs

@povilasv povilasv marked this pull request as ready for review August 9, 2022 07:46
@povilasv povilasv requested a review from a team August 9, 2022 07:46
@povilasv povilasv requested a review from dmitryax as a code owner August 9, 2022 07:46
dmitryax
dmitryax approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit f5c8156 into open-telemetry:main Aug 9, 2022
@povilasv povilasv deleted the k8sattributes-job branch August 9, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @dmitryax