[storagetest] Build out package for more flexible test cases #13086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
storagetest-memory-extension
branch
3 times, most recently
from
170be10 to
709863b
Compare
djaglowski
force-pushed
the
storagetest-memory-extension
branch
from
709863b to
41068c0
Compare
|
@open-telemetry/collector-contrib-approvers, PTAL. This will enable sufficient testing on #12871. |
The storagetest package exists to enable testing the usage of storage extensions. This PR extends and cleans up the package so that it can be used for a far larger set of test cases.
djaglowski
force-pushed
the
storagetest-memory-extension
branch
from
41068c0 to
82f1bb0
Compare
|
@collector-contrib-approvers, is anyone able to please review this? |
dmitryax
approved these changes
Aug 17, 2022
|
@djaglowski this broke tests -- branches based on the current main are failing the impi tests: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/2877610894 |
|
I am working on a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storagetest package exists to enable testing the usage of
storage extensions. This PR extends and cleans up the package
so that it can be used for a far larger set of test cases.