-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tqlotel] Add priority keys parameter to the limit function. #12997
[tqlotel] Add priority keys parameter to the limit function. #12997
Conversation
52ad9d5
to
0b50df2
Compare
0b50df2
to
1cb5e72
Compare
/cc @kentquirk |
@bogdandrutu @TylerHelmuth can you please review the PR? |
1cb5e72
to
51dffa2
Compare
25bfc95
to
a106878
Compare
bed186a
to
252ac52
Compare
252ac52
to
65158cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I made one minor documentation suggestion.
Co-authored-by: Kent Quirk <[email protected]>
529649e
to
6da9e8f
Compare
`priority_keys` is a list of strings of attribute keys that won't be dropped during limiting. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is not a list is a variadic argument. I mean this means we cannot add arguments after and we don't need to use join/concat/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerHelmuth how do we call these arguments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a limitation of the grammar at the moment. The grammar only supports 1 list parameter and it must be the last. Yes it is technically variadic, but I believe the docs currently call it a list. There is open issue to add full list capabilities.
Description:
Add ability to specify attributes that aren't allowed to be dropped during limiting. Resolves #9734.
Link to tracking Issue:
#9734
Testing:
and testing with
Documentation:
Updated:
pkg/telemetryquerylanguage/functions/tqlotel/README.md
processor/transformprocessor/README.md