[tqlotel] Avoid copying when filtering keys in KeepKeys. #12995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
approved these changes
Aug 8, 2022
kovrus
force-pushed
the
tqlotel/improve-keep-keys
branch
3 times, most recently
from
72ebb75 to
7b52d1e
Compare
Uses `AttributeMap#RemoveIf` introduced in open-telemetry/opentelemetry-collector#4914, also see open-telemetry/opentelemetry-collector#4756
kovrus
force-pushed
the
tqlotel/improve-keep-keys
branch
from
7b52d1e to
bd951e1
Compare
|
/cc @kentquirk |
|
@TylerHelmuth can you please review the PR? |
|
@dashpole can you please take a look at it again and maybe merge it? |
|
We should make sure a codeowner takes a look |
kentquirk
approved these changes
Aug 12, 2022
|
@kovrus I am on PTO but will review next week if still needed. |
TylerHelmuth
approved these changes
Aug 15, 2022
TylerHelmuth
added
the
ready to merge
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses
AttributeMap#RemoveIfintroduced in #4914, also see #4756.Link to tracking Issue:
open-telemetry/opentelemetry-collector#4756
Testing:
Existing unit tests.
Documentation: