[receiver/jaegerreceiver] Remove jaeger remote sampling from receiver #12940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Bongartz <[email protected]>
Signed-off-by: Benedikt Bongartz <[email protected]>
frzifus
changed the title
jpkrohling
reviewed
Aug 8, 2022
| defaultHTTPBindEndpoint = "0.0.0.0:14268" | ||
| defaultThriftCompactBindEndpoint = "0.0.0.0:6831" | ||
| defaultThriftBinaryBindEndpoint = "0.0.0.0:6832" | ||
| defaultAgentRemoteSamplingHTTPEndpoint = "0.0.0.0:5778" |
There was a problem hiding this comment.
Sorry, I should have been clearer on the original issue: we should remove this, but we need to first deprecate for at least a couple of versions. So, at this point, we need to only detect whether this is being used and log a info/warn-level message, stating that this port will disappear by version X (0.60.0 is the earliest at this point, I believe).
There was a problem hiding this comment.
i am addressing this in #13408 and closing the pr until we finally remove the endpoint.
6 tasks
frzifus
deleted the
remove_jaeger_remote_sampling_from_receiver_#6633
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Remove jaeger remote sampling from jaegerreceiver
Link to tracking Issue: #6633
Testing: adapt unittest
Documentation:
Maybe we should wait for #12788