Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azureeventhub] Add new component, Azure Event Hub Receiver #12787

Merged
merged 1 commit into from
Aug 5, 2022
Merged

[receiver/azureeventhub] Add new component, Azure Event Hub Receiver #12787

merged 1 commit into from
Aug 5, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Jul 30, 2022

Description:
Structure of a new receiver for Azure event hub.

Link to tracking Issue:
#12786

Testing:
N/A

Documentation:
README.md

@atoulme atoulme requested review from a team and jpkrohling July 30, 2022 05:55
@atoulme atoulme force-pushed the azure_eventhub branch 2 times, most recently from fd59014 to c27eae0 Compare July 30, 2022 07:03
@atoulme atoulme requested a review from mx-psi as a code owner July 30, 2022 07:03
@atoulme atoulme force-pushed the azure_eventhub branch 5 times, most recently from df39aa7 to 847b731 Compare July 30, 2022 14:40
@jpkrohling jpkrohling removed their request for review August 1, 2022 15:16
bogdandrutu
bogdandrutu reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI only: Have not looked at the code, but consider to use same pattern as kafka receiver that allows plugin different "Unmarshaller" (otlp, etc.)

@atoulme atoulme force-pushed the azure_eventhub branch 4 times, most recently from 84e5bec to 4256722 Compare August 3, 2022 17:10
@atoulme
Copy link
Contributor Author

atoulme commented Aug 3, 2022

yes, this is just the structure, the impl is not set yet. Good call on the unmarshaller.

@atoulme atoulme force-pushed the azure_eventhub branch 5 times, most recently from e7ea412 to 575b8b7 Compare August 5, 2022 04:19
@atoulme
Copy link
Contributor Author

atoulme commented Aug 5, 2022

@djaglowski I am having issues with flaky tests, please review as I try one more time to get a green build...

djaglowski
djaglowski reviewed Aug 5, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as stability is changed to "in development".

I haven't seen much test flakiness lately. If you can link me to any failures, I'd like to at least capture them.

receiver/azureeventhubreceiver/README.md Outdated Show resolved Hide resolved
@atoulme atoulme requested a review from djaglowski August 5, 2022 18:36
@djaglowski djaglowski merged commit e5b6bcc into open-telemetry:main Aug 5, 2022
@atoulme atoulme deleted the azure_eventhub branch August 5, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@djaglowski djaglowski djaglowski approved these changes

@mx-psi mx-psi Awaiting requested review from mx-psi

Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @bogdandrutu @djaglowski @codeboten