[receiver/kubeletstatsreceiver] Emit network metrics without a direction attribute #12588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
force-pushed
the
kubeletstats_direction
branch
from
b8272f4 to
405807b
Compare
mwear
force-pushed
the
kubeletstats_direction
branch
2 times, most recently
from
eda8a45 to
1cd7138
Compare
dmitryax
reviewed
Jul 27, 2022
| 1. v0.56.0, July 2022: | ||
|
|
||
| - The new metrics are available for all scrapers, but disabled by default, they can be enabled with the feature gates. | ||
| - The old metrics with `direction` attribute are deprecated with a warning. |
There was a problem hiding this comment.
The warning log still needs to be added
There was a problem hiding this comment.
I added warnings. In doing so, I noticed that some were removed in this PR: #12105. They were supposed to be added back in before the v0.56.0 release, but it doesn't appear that happened. I can make an issue and add them back if that's something we'd like to do. I used the phrasing from the original warnings. If we'd like to make any changes, suggest them here and I can apply them when adding the warnings elsewhere.
mwear
force-pushed
the
kubeletstats_direction
branch
3 times, most recently
from
3e5c01c to
c7530b3
Compare
mwear
force-pushed
the
kubeletstats_direction
branch
from
c7530b3 to
6d1359c
Compare
dmitryax
approved these changes
Aug 10, 2022
dmitryax
reviewed
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the kubeletstatsreceiver so that it can emit metrics without a direction attribute (see #11815). The behavior of the direction attribute is currently controlled by the feature gates
receiver.kubeletstatsreceiver.emitMetricsWithoutDirectionAttributeandreceiver.kubeletstatsreceiver.emitMetricsWithDirectionAttribute. The feature gates will be available for a grace period to help users transition to metrics without a direction attribute, which will eventually become the default.Link to tracking Issue:
#12164
Testing:
Unit tests
Documentation:
The readme has been updated to document the feature gates and transition plan.