[exporter/prometheus] fix: cumulative condition based on the starttimestamp #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Loc Mai <[email protected]>
locmai
force-pushed
the
fix/cumulative-condition
branch
from
8bb9309 to
0a47c01
Compare
Signed-off-by: Loc Mai <[email protected]>
This reverts commit 6717c52. Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
jmacd
reviewed
Jul 12, 2022
The
With the tests, it would be covered: However, the tests seem to produce the same all passed result but with less coverage with the incorrect condition:
Let me add more assertions into that to make it right. |
Signed-off-by: Loc Mai <[email protected]>
Signed-off-by: Loc Mai <[email protected]>
locmai
commented
Jul 13, 2022
| @@ -444,8 +447,9 @@ func TestAccumulateDeltaToCumulative(t *testing.T) { | |||
| }) | |||
| require.Equal(t, mLabels.Len(), vLabels.Len()) | |||
| require.Equal(t, mValue, vValue) | |||
| require.Equal(t, dataPointValue1+dataPointValue2, vValue) | |||
There was a problem hiding this comment.
Adding this assertion would fail the bug in comparison between the first and second data points timestamp.
jmacd
approved these changes
Jul 13, 2022
Aneurysm9
approved these changes
Jul 16, 2022
mx-psi
changed the title
mx-psi
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing the erroneous change in this commit e7ab883#diff-9822bc07132ceeeb9c69a90898caccf2d9f9acefe0cef5b5bae0dc2cc9e44764R213
which it should be comparing between the startTimestamp of the next data point to the Timestamp of the last data point.
Link to tracking Issue: N/A
Testing:
The similar way in #9919