-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/hostmetrics] remove direction attribute #11820
[receiver/hostmetrics] remove direction attribute #11820
Conversation
c11169d
to
aef3030
Compare
I think this receiver is stable enough to avoid making such breaking changes. I believe many distributions depend on it. Can we make it through a feature gate (or enabling/disabling metrics) spanned across several versions in the following way? |
Would this warning show up at collector start? |
Yes, we've done this many times for such breaking changes |
The following change adds the direction to the metric name, removing the `direction` attribute. Fixes #11817
aef3030
to
c9e63c4
Compare
@dmitryax it's behind a feature gate now, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overal LGTM
receiver/hostmetricsreceiver/internal/scraper/networkscraper/metadata.yaml
Show resolved
Hide resolved
i have a quetion: why set the some metric to |
@sweetpotato0 thanks for pointing to this. The deprecated labels should've been removed some time ago. I submitted #16227 to fix it |
The following change adds the direction to the metric name, removing the
direction
attribute.Fixes #11817