pkg/stanza: use ObservedTimestamp to decide if flush log for recombine operator #11433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to decide if flush log Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
changed the title
Signed-off-by: Dominik Rosiek <[email protected]>
djaglowski
approved these changes
Jun 22, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Now Timestamp is taken into consideration while deciding to flush log in recombine operator.
The issue is that timestamp comes from log body and can be behind the time log has been read.
Switching it to
ObservedTimestamp, so time of reading logs will be taken insteadLink to tracking Issue: N/A
Testing: manual only