Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for rabbitmq receiver #11049

Merged
merged 14 commits into from
Jun 20, 2022
Merged

Add integration test for rabbitmq receiver #11049

merged 14 commits into from
Jun 20, 2022

Conversation

Frapschen
Copy link
Contributor

Description: Add integration test for rabbitmq receiver

resolved #10865

@Frapschen Frapschen requested a review from a team June 15, 2022 03:31
@Frapschen Frapschen requested a review from djaglowski as a code owner June 15, 2022 03:31
@Frapschen
Copy link
Contributor Author

@djaglowski revew pls :)

djaglowski
djaglowski reviewed Jun 15, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. A few minor comments though.

receiver/mysqlreceiver/README.md Outdated Show resolved Hide resolved
receiver/rabbitmqreceiver/testdata/integration/scripts/setup.sh Outdated Show resolved Hide resolved
receiver/rabbitmqreceiver/testdata/integration/scripts/setup.sh Outdated Show resolved Hide resolved
receiver/rabbitmqreceiver/testdata/integration/Dockerfile.rabbitmq.3_9 Outdated Show resolved Hide resolved
@Frapschen Frapschen requested a review from djaglowski June 16, 2022 14:59
@djaglowski
Copy link
Member

@Frapschen, thank you. This looks good to me. Please resolve conflicts

@Frapschen
Merge branch 'main' into Add_integration_test_for_rabbitmq_receiver
841919a 
# Conflicts:
#	CHANGELOG.md
#	receiver/rabbitmqreceiver/go.mod
@Frapschen
Copy link
Contributor Author

@djaglowski resolved. I want to apply become a member of opentelemetry community,can you sponsored me?

@djaglowski
Copy link
Member

👍 Happy to sponsor you @Frapschen. Thanks for all your contributions so far.

@djaglowski
Copy link
Member

Looks like some new CI failures with that most recent push

Frapschen added 3 commits June 17, 2022 21:46
@Frapschen
Merge branch 'main' into Add_integration_test_for_rabbitmq_receiver
953e6d5 
# Conflicts:
#	CHANGELOG.md
#	receiver/rabbitmqreceiver/go.mod
@Frapschen
Merge remote-tracking branch 'origin/Add_integration_test_for_rabbitm…
691ada8 
…q_receiver' into Add_integration_test_for_rabbitmq_receiver

# Conflicts:
#	CHANGELOG.md
#	receiver/rabbitmqreceiver/go.mod
@Frapschen
update
dcf4478
@Frapschen Frapschen mentioned this pull request Jun 17, 2022
Closed
6 tasks
@Frapschen
Copy link
Contributor Author

@djaglowski fixed

@djaglowski
Copy link
Member 

=== CONT  TestRabbitmqIntegration/Running_rabbitmq_3.9
    integration_test.go:93: 
        	Error Trace:	integration_test.go:93
        	            				integration_test.go:50
        	Error:      	Received unexpected error:
        	            	Error response from daemon: could not find plugin bridge in v1 plugin registry: plugin not found: failed to create container
        	Test:       	TestRabbitmqIntegration/Running_rabbitmq_3.9
--- FAIL: TestRabbitmqIntegration (0.00s)
    --- FAIL: TestRabbitmqIntegration/Running_rabbitmq_3.9 (15.28s)

@Frapschen
Copy link
Contributor Author

probably miss the two line?

//go:build integration
// +build integration

@Frapschen
Copy link
Contributor Author

the only two pipline errors is not related

@Frapschen
Copy link
Contributor Author

@djaglowski need review pls :)

djaglowski
djaglowski approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Frapschen!

@djaglowski
Copy link
Member 

Running target 'do-integration-tests-with-cover' in module 'receiver/rabbitmqreceiver' as part of group 'all'
make -C receiver/rabbitmqreceiver "do-integration-tests-with-cover"
make[1]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/rabbitmqreceiver'
running go integration test ./... + coverage in /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/rabbitmqreceiver
=== RUN   TestRabbitmqIntegration
=== RUN   TestRabbitmqIntegration/Running_rabbitmq_3.9
=== PAUSE TestRabbitmqIntegration/Running_rabbitmq_3.9
=== CONT  TestRabbitmqIntegration/Running_rabbitmq_3.9
2022/06/20 03:06:59 Starting container id: d4df58b33a08 image: docker.io/testcontainers/ryuk:0.3.3
2022/06/20 03:07:00 Waiting for container id d4df58b33a08 image: docker.io/testcontainers/ryuk:0.3.3
2022/06/20 03:07:00 Container is ready id: d4df58b33a08 image: docker.io/testcontainers/ryuk:0.3.3
2022/06/20 03:07:07 Starting container id: 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
2022/06/20 03:07:07 Waiting for container id 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
2022/06/20 03:07:13 Container is ready id: 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
2022/06/20 03:07:17 Starting container id: 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
2022/06/20 03:07:17 Waiting for container id 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
2022/06/20 03:07:17 Container is ready id: 58b571e5967d image: 4abcccfc-84aa-42c6-91eb-34d5643b1737:0d6407ff-3b19-4598-817c-64cacb4a27d5
--- PASS: TestRabbitmqIntegration (0.00s)
    --- PASS: TestRabbitmqIntegration/Running_rabbitmq_3.9 (28.71s)
PASS
coverage: 63.1% of statements
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/rabbitmqreceiver	28.[772](https://github.com/open-telemetry/opentelemetry-collector-contrib/runs/6959785527?check_suite_focus=true#step:5:773)s	coverage: 63.1% of statements

@djaglowski djaglowski merged commit 0d6e445 into open-telemetry:main Jun 20, 2022
@Frapschen Frapschen deleted the Add_integration_test_for_rabbitmq_receiver branch July 7, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[receiver/rabbitmq] Add integration test
3 participants
@Frapschen @djaglowski @jpkrohling