feat(dynatraceexporter): provide better estimated summaries for partial histograms #11044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
changed the title
pirgeo
approved these changes
Jun 15, 2022
joaopgrassi
reviewed
Jun 15, 2022
| // range for counts[i] is bounds[i-1] to bounds[i] | ||
|
|
||
| // min estimation | ||
| if !foundNonEmptyBucket { |
There was a problem hiding this comment.
Hum.. not sure I get the motive of this var here? Couldn't we just check if it's i == 0 it will only go inside once..🤔
There was a problem hiding this comment.
The first non-empty bucket might not be the first bucket.
|
The CI failure is in "check-codeowners" but it isn't at all obvious what that check is even doing to me |
|
Load and stability tests have been running for ~3 hours. is that right? |
nah there is an issue. I recommend taking latest from main to force another round of actions. |
|
I'm pretty sure the CI failures are unrelated |
TylerHelmuth
approved these changes
Jun 18, 2022
joaopgrassi
approved these changes
Jun 20, 2022
TylerHelmuth
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynatrace exporter converts histograms to stat summary gauges. This PR improves the estimation in the following ways: