[processor/transform] Add functionality to break up a summary metric into Sum metrics. #11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrod1598
force-pushed
the
expand-transform-processor
branch
from
560f5a5 to
0ac6815
Compare
antonblock
reviewed
Jun 14, 2022
Mrod1598
requested review from
Aneurysm9,
bogdandrutu and
TylerHelmuth
as code owners
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum_test.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum_test.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum_test.go
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_sum_val_to_sum_test.go
Outdated
Show resolved
Hide resolved
processor/transformprocessor/internal/metrics/func_convert_summary_count_val_to_sum.go
Show resolved
Hide resolved
|
/cc @anuraaga |
added 2 commits
June 17, 2022 09:19
|
@TylerHelmuth thanks for Reviewing! Can this merge or are we waiting on another review? |
|
We like to get at least 2 approvals for most things. @anuraaga @open-telemetry/collector-contrib-approvers please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Resolves #10824
Testing:
Added tests for new functions. Tested processor against a real vault instance as well using the prometheus receiver.
Documentation:
Added To README describing the new functions.