Add IgnoreResourceAttributeValue CompareOption #10828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
reviewed
Jun 7, 2022
Copy IgnoreMetricAttributeValue pattern to remove specified resource attribute for comparison. Add unit tests.
antonblock
force-pushed
the
ignore-resource-attribute-value
branch
from
1a49e61 to
1e2d848
Compare
|
I added a test to see how easy it is to induce a false failure, and unfortunately it appears to be problematic. That said, I think there are cases where we can still benefit from this functionality as is, such as #10165. It seems to me that to handle unordered slices of resources/scopes/datapoints, we should add sortation functions to this package, which could be called before comparisons are made. The sortation likely needs to be sensitive to the same CompareOptions so that expected variables (unpredictable values, times, etc) do not influence the sort. I'll open another issue for this. |
djaglowski
approved these changes
Jun 8, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
* Add IgnoreResourceAttributeValue CompareOption Copy IgnoreMetricAttributeValue pattern to remove specified resource attribute for comparison. Add unit tests. * Update CHANGELOG.md
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds
IgnoreResourceAttributeValueCompareOption, copying pattern ofIgnoreMetricAttributeValue. This new option removes resource attributes from expected and actual metrics when comparing metrics. This is desirable for integration tests in cases where a resource attribute is unpredictable, for example random UUID or MAC address.Link to tracking Issue: #10129
Testing: Additional test cases were added to
TestCompareMetricsusing the new option. The cases test masking the sole resource attribute from a resource, and removing masking one attribute but preserving other predictable attributes.Documentation: The exported
IgnoreResourceAttributeValuemethod is documented with a description of what it does