-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate Google Pubsub receiver and exporter #10580
Activate Google Pubsub receiver and exporter #10580
Conversation
20586f1
to
75d7d3c
Compare
75d7d3c
to
14b2ad9
Compare
I appreciate the help here. I'll wait for the main committers to have a look first. I hope you have better luck with the workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified stability by running the branch locally. Worked directly. Now we need someone to unlock the test flows.
@codeboten could you unlock tests? |
14b2ad9
to
efacd20
Compare
@codeboten @alexvanboxel @jpkrohling The previous run failed with just the checklinks job. One of the links 404'ed but it wasn't relative to this commit - I'm guessing it may have been a temporary issue. I pushed up a new rebase to try and trigger the workflow again. but it looks like I need reapproval to run. For future reference is it possible to rerun a single job if it fails? Can we please get permission to run this again? Thanks! |
56b819a
to
efacd20
Compare
Until your first PR to this repo is merged, each test run will have to be approved manually by an approver. Failed jobs can typically be restarted in isolation, but it depends on their relation to other jobs. |
As noted in the original PR, once this is merged, please make sure to add these components to the contrib distribution: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml |
efacd20
to
61f2eb6
Compare
61f2eb6
to
d9867b7
Compare
PR was rebased this morning and rebuilt/tested locally successfully. I've corrected issues brought up by @djaglowski in code review. Thank you! CC: @alexvanboxel |
Created a PR in open-telemetry/opentelemetry-collector-releases#147 to add this for distribution. Thanks for the help everyone! |
Description:
Activates the Google Pubsub receiver and exporter components.
Resurrects: #8853
Link to tracking Issue:
#1802
Testing:
Per original PR these components have been in production at Collibra