Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate Google Pubsub receiver and exporter #10580

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

hex1848
Copy link
Contributor

@hex1848 hex1848 commented Jun 3, 2022

Description:

Activates the Google Pubsub receiver and exporter components.

Resurrects: #8853

Link to tracking Issue:

#1802

Testing:

Per original PR these components have been in production at Collibra

@hex1848 hex1848 requested review from a team and Aneurysm9 June 3, 2022 02:09
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: hex1848 / name: Miguel Gonzalez (75d7d3ce92a5d7fc65a304b807045db23cc3e0a2)

@alexvanboxel
Copy link
Contributor

I appreciate the help here. I'll wait for the main committers to have a look first. I hope you have better luck with the workflows.

Copy link
Contributor

@alexvanboxel alexvanboxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified stability by running the branch locally. Worked directly. Now we need someone to unlock the test flows.

@alexvanboxel
Copy link
Contributor

@codeboten could you unlock tests?

@hex1848 hex1848 force-pushed the feature/pubsub-activate branch from 14b2ad9 to efacd20 Compare June 3, 2022 22:39
@hex1848
Copy link
Contributor Author

hex1848 commented Jun 3, 2022

@codeboten @alexvanboxel @jpkrohling

The previous run failed with just the checklinks job. One of the links 404'ed but it wasn't relative to this commit - I'm guessing it may have been a temporary issue. I pushed up a new rebase to try and trigger the workflow again. but it looks like I need reapproval to run.

For future reference is it possible to rerun a single job if it fails? Can we please get permission to run this again?

Thanks!

@hex1848 hex1848 force-pushed the feature/pubsub-activate branch from 56b819a to efacd20 Compare June 7, 2022 14:13
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
internal/components/receivers_test.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member

For future reference is it possible to rerun a single job if it fails? Can we please get permission to run this again?

Until your first PR to this repo is merged, each test run will have to be approved manually by an approver. Failed jobs can typically be restarted in isolation, but it depends on their relation to other jobs.

@djaglowski
Copy link
Member

As noted in the original PR, once this is merged, please make sure to add these components to the contrib distribution: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/distributions/otelcol-contrib/manifest.yaml

@hex1848 hex1848 force-pushed the feature/pubsub-activate branch from efacd20 to 61f2eb6 Compare June 7, 2022 14:51
@hex1848 hex1848 force-pushed the feature/pubsub-activate branch from 61f2eb6 to d9867b7 Compare June 7, 2022 14:54
@hex1848
Copy link
Contributor Author

hex1848 commented Jun 7, 2022

PR was rebased this morning and rebuilt/tested locally successfully. I've corrected issues brought up by @djaglowski in code review. Thank you!

CC: @alexvanboxel

@hex1848
Copy link
Contributor Author

hex1848 commented Jun 8, 2022

Created a PR in open-telemetry/opentelemetry-collector-releases#147 to add this for distribution. Thanks for the help everyone!

kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants