Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsemfexporter] Include min and max for histograms when available #10577

Merged

Conversation

alexperez52
Copy link
Contributor

Description:

Add min and max for histograms when available. Min and max are optional.

Link to tracking Issue:
#10545

Testing:
Added two tests

  1. Test that min and max can be set
  2. Test that if min and max are not set, they default to 0

@alexperez52 alexperez52 requested a review from a team June 2, 2022 18:17
@alexperez52 alexperez52 requested a review from Aneurysm9 as a code owner June 2, 2022 18:17
Co-authored-by: Anthony Mirabella <[email protected]>
@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Jun 3, 2022
@codeboten codeboten merged commit 74155f1 into open-telemetry:main Jun 3, 2022
@alexperez52 alexperez52 deleted the update-awsemfexporter-min-max branch June 3, 2022 21:32
kentquirk pushed a commit to McSick/opentelemetry-collector-contrib that referenced this pull request Jun 14, 2022
…ilable (open-telemetry#10577)

* Added datapoint tests for HistogramDataPointSliceAt min & max

* new feature added: awsemf exporter needs to be updated to include min/max for histograms

* Added tests to awsemfexporter datapoint for histogram min & max

* Merge

* gofmt & update changelog

* Update CHANGELOG.md

Co-authored-by: Anthony Mirabella <[email protected]>

Co-authored-by: Junhao Yu <[email protected]>
Co-authored-by: Junhao Yu <[email protected]>
Co-authored-by: Anthony Mirabella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants