[processor/transform] Flatten functions #10489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
Skip Changelog
|
/cc @anuraaga |
djaglowski
reviewed
Jun 6, 2022
| "go.opentelemetry.io/collector/pdata/pmetric" | ||
| ) | ||
|
|
||
| func Test_convert_gauge_to_sum(t *testing.T) { |
There was a problem hiding this comment.
I'm not sure there's really a benefit to matching the test name style (snake case). It should be easy enough to correlate using normal syntax.
There was a problem hiding this comment.
My intention was actual to match the query language syntax, but I will use the actual Go function name instead bc that is what is being tested.
There was a problem hiding this comment.
@djaglowski updated test function names
djaglowski
approved these changes
Jun 8, 2022
kentquirk
pushed a commit
to McSick/opentelemetry-collector-contrib
that referenced
this pull request
Jun 14, 2022
* Add all existing scenarios to reflection * Update tests to only test NewFunctionCall * Break out switch statements * Small adjustments * Update changelog * Added testhelper * moved functions into their own files * added tests for keep_keys and limit * Switched tests to use generic ctx instead of trace * updated more tests * removed all instances of ptrace from common * fix merge * flattened metric functions * Simplify test context * Fix lint issues * Fix lint issues * Fix lint issues * ran make gotidy * Update test function names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is the next step towards our ongoing function refactor. This PR moves each function into its own file with its own test file. This makes it easier to:
NewFunctionCall. For functions incommon, they can now be tested independently of any specific signal.functions.goto register it. A CONTRIBUTING.md will be added in a separate PR.This PR does introduce a significant number of duplicate tests. Once this PR is merged I plan to remove all the duplicate tests from the signal-specific
functions.gofiles.Link to tracking Issue:
#10101
Testing:
Updated unit tests
Documentation:
This is a no-functionality change, so all existing documentation is correct.