-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/tanzuobservability] exponential histogram adjustment. #10135
Conversation
Get rid of the extra negative bucket which always has a count of 0.
cc @oppegard @thepeterstone |
@oppegard and @thepeterstone are the Tech Leads, but they are both out of the office for now. @deosu is going to review the code first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the future, it is useful to open issues in this repository (even if you already have issues elsewhere) describing the issue you encountered so others facing the same problem can find it and see the fix here.
…-telemetry#10135) [exporter/tanzuoservability] exponential histogram adjustment. Get rid of the extra negative bucket which always has a count of 0. Co-authored-by: Alex Boten <[email protected]>
Description:
Get rid of the smallest negative bucket which always has a count of 0. This smallest negative bucket with count of 0 was here to give the bucket above it a lower bound. But during testing we found that most histograms have positive values anyway. It was confusing to see a "<= -1" bucket show up all the time, so we decided to get rid of this bucket.
Link to tracking Issue: Issue is private and not linkable.
Testing: Unit tests and manual testing with the collector.