Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/loki] Ensure Validate implementation does the right thing #7841

Closed
codeboten opened this issue Feb 11, 2022 · 5 comments
Closed

[exporter/loki] Ensure Validate implementation does the right thing #7841

codeboten opened this issue Feb 11, 2022 · 5 comments
Assignees
@shree007
Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codeboten
Copy link
Contributor

This change in the collector core added a Validate method to QueueSettings which caused ambiguity with the ExporterSettings’ Validate method. As a result, I’ve added a Validate method to this exporter and an issue to ensure it was doing the right thing.

Here is an example of the validate method for the OTLP exporter calling the QueueSettings’ Validate

open-telemetry/opentelemetry-collector@48c402d#diff-a56037437974f775001642d59880ac9dd0c14cab137576b4f4a6df01a230a84cR39-R42

Originally posted by @codeboten in #7779 (comment)
@codeboten codeboten added help wanted Extra attention is needed good first issue Good for newcomers comp:grafanalabs Grafana Labs components - Loki, Grafana labels Feb 11, 2022
@shree007
Copy link
Contributor

@codeboten I may work on it.

@codeboten
Copy link
Contributor Author

thanks @shree007!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 8, 2022
@jpkrohling
Copy link
Member

@mar4uk, would you be able to take a look at this and see if it's still relevant?

@jpkrohling jpkrohling added exporter/loki Loki Exporter and removed Stale labels Nov 21, 2022
@mar4uk mar4uk mentioned this issue Dec 12, 2022
Merged
codeboten pushed a commit that referenced this issue Jan 17, 2023
@mar4uk
[exporter/loki] Add Config QueueSettings validation (#16855)
3f56ff9 
Description: Added QueueStettings validation into Config Validate method
Link to tracking Issue: #7841
@codeboten
Copy link
Contributor Author

Fixed by #16855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shree007 shree007

Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpkrohling @codeboten @shree007