Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build deb/rpm/msi are failing #6092

Closed
codeboten opened this issue Nov 1, 2021 · 3 comments · Fixed by #6091
Closed

Build deb/rpm/msi are failing #6092

codeboten opened this issue Nov 1, 2021 · 3 comments · Fixed by #6091
Assignees
@codeboten
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

The following build jobs are failing in multiple builds.

Screen Shot 2021-11-01 at 4 12 01 PM
@codeboten codeboten added the bug Something isn't working label Nov 1, 2021
@codeboten codeboten self-assigned this Nov 1, 2021
@codeboten codeboten mentioned this issue Nov 1, 2021
Merged
@codeboten
Copy link
Contributor Author

The problem began as a result of this change being merged #5666

tigrannajaryan pushed a commit that referenced this issue Nov 2, 2021
example for thrift exporter was using invalid config (#6091)
6c21bf2 
This was causing the fpm/deb/msi build targets to fail because examples/tracing/otel-collector-config.yml is used the rpm/deb build https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/050ccc1a723abba703864617d839ebd19cb00f45/.github/workflows/build-and-test.yml#L289.

Fixes #6092
@jpkrohling
Copy link
Member

Thanks for fixing this, @codeboten. My bad, should have not ignored the check failures in that PR.

@codeboten
Copy link
Contributor Author

Thanks for fixing this, @codeboten. My bad, should have not ignored the check failures in that PR.

No problem... It's a side effect of too many checks failing :(

liqiangz pushed a commit to liqiangz/opentelemetry-collector-contrib that referenced this issue Nov 3, 2021
@liqiangz
example for thrift exporter was using invalid config (open-telemetry#…
3466db5 
…6091)

This was causing the fpm/deb/msi build targets to fail because examples/tracing/otel-collector-config.yml is used the rpm/deb build https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/050ccc1a723abba703864617d839ebd19cb00f45/.github/workflows/build-and-test.yml#L289.

Fixes open-telemetry#6092
povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@dmitryax
[pdata] Expose pcommon.Value.AsRaw/FromRaw methods (#6092)
4cf5f82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jpkrohling @codeboten