Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exporter/datadog: doesn't support metrics and does not log this fact #4

Closed
flands opened this issue Jul 3, 2019 · 3 comments
Closed

exporter/datadog: doesn't support metrics and does not log this fact #4

flands opened this issue Jul 3, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@flands
Copy link
Contributor

flands commented Jul 3, 2019

For more details see: census-instrumentation/opencensus-service#454
@MohamedElqdusy
Copy link
Contributor

As stated here Datadog is not one of the core exporters, isn't it?

@flands
Copy link
Contributor Author

flands commented Jul 9, 2019

That is correct -- it will move to the contrib repo once created. Temporary move over to clean up OC issues.

@pjanotti pjanotti transferred this issue from open-telemetry/opentelemetry-collector Jul 11, 2019
@tigrannajaryan tigrannajaryan added the help wanted Extra attention is needed label Apr 22, 2020
@flands
Copy link
Contributor Author

flands commented May 21, 2020

N/A to otel at this time so closing

@flands flands closed this as completed May 21, 2020
jjackson-s referenced this issue in jjackson-s/opentelemetry-collector-contrib Aug 9, 2021
@jjackson-s
Merge pull request #4 from jjackson-s/cfgwiz2
80728ad 
Rebasing extension
@jvoravong jvoravong mentioned this issue Jun 8, 2022
Closed
@daoweili daoweili mentioned this issue Apr 26, 2023
Closed
kasia-kujawa referenced this issue in kasia-kujawa/opentelemetry-collector-contrib May 18, 2023
@kasia-kujawa
feat(sqlqueryreceiver) add error count metrics for receiver (#4)
a63f68b
sky333999 added a commit to sky333999/opentelemetry-collector-contrib that referenced this issue May 23, 2023
@sky333999
[receiver/awscontainerinsightreceiver] Parameterize EKS CI leader loc… (
5cc5b76 
open-telemetry#4)

[receiver/awscontainerinsightreceiver] Parameterize EKS CI leader lock name
@sairamsadanala sairamsadanala mentioned this issue Sep 14, 2023
Closed
TylerHelmuth added a commit that referenced this issue Sep 21, 2024
@daidokoro @kentquirk @TylerHelmuth
[processor/transform] Add Conversion Function to OTTL for Exponential…
74b1048 
… Histo --> Histogram (#33824)

## Description

This PR adds a custom metric function to the transformprocessor to
convert exponential histograms to explicit histograms.

Link to tracking issue: Resolves #33827

**Function Name**
```
convert_exponential_histogram_to_explicit_histogram
```

**Arguments:**

- `distribution` (_upper, midpoint, uniform, random_)
- `ExplicitBoundaries: []float64`

**Usage example:**

```yaml
processors:
  transform:
    error_mode: propagate
    metric_statements:
    - context: metric
      statements:
        - convert_exponential_histogram_to_explicit_histogram("random", [10.0, 20.0, 30.0, 40.0, 50.0, 60.0, 70.0, 80.0, 90.0, 100.0]) 
```

**Converts:**

```
Resource SchemaURL: 
ScopeMetrics #0
ScopeMetrics SchemaURL: 
InstrumentationScope  
Metric #0
Descriptor:
     -> Name: response_time
     -> Description: 
     -> Unit: 
     -> DataType: ExponentialHistogram
     -> AggregationTemporality: Delta
ExponentialHistogramDataPoints #0
Data point attributes:
     -> metric_type: Str(timing)
StartTimestamp: 1970-01-01 00:00:00 +0000 UTC
Timestamp: 2024-07-31 09:35:25.212037 +0000 UTC
Count: 44
Sum: 999.000000
Min: 40.000000
Max: 245.000000
Bucket (32.000000, 64.000000], Count: 10
Bucket (64.000000, 128.000000], Count: 22
Bucket (128.000000, 256.000000], Count: 12
        {"kind": "exporter", "data_type": "metrics", "name": "debug"}
```

**To:**

```
Resource SchemaURL: 
ScopeMetrics #0
ScopeMetrics SchemaURL: 
InstrumentationScope  
Metric #0
Descriptor:
     -> Name: response_time
     -> Description: 
     -> Unit: 
     -> DataType: Histogram
     -> AggregationTemporality: Delta
HistogramDataPoints #0
Data point attributes:
     -> metric_type: Str(timing)
StartTimestamp: 1970-01-01 00:00:00 +0000 UTC
Timestamp: 2024-07-30 21:37:07.830902 +0000 UTC
Count: 44
Sum: 999.000000
Min: 40.000000
Max: 245.000000
ExplicitBounds #0: 10.000000
ExplicitBounds #1: 20.000000
ExplicitBounds #2: 30.000000
ExplicitBounds #3: 40.000000
ExplicitBounds #4: 50.000000
ExplicitBounds #5: 60.000000
ExplicitBounds #6: 70.000000
ExplicitBounds #7: 80.000000
ExplicitBounds #8: 90.000000
ExplicitBounds #9: 100.000000
Buckets #0, Count: 0
Buckets #1, Count: 0
Buckets #2, Count: 0
Buckets #3, Count: 2
Buckets #4, Count: 5
Buckets #5, Count: 0
Buckets #6, Count: 3
Buckets #7, Count: 7
Buckets #8, Count: 2
Buckets #9, Count: 4
Buckets #10, Count: 21
        {"kind": "exporter", "data_type": "metrics", "name": "debug"}
```

### Testing

- Several unit tests have been created. We have also tested by ingesting
and converting exponential histograms from the `statsdreceiver` as well
as directly via the `otlpreceiver` over grpc over several hours with a
large amount of data.

- We have clients that have been running this solution in production for
a number of weeks.

### Readme description:

### convert_exponential_hist_to_explicit_hist

`convert_exponential_hist_to_explicit_hist([ExplicitBounds])`

the `convert_exponential_hist_to_explicit_hist` function converts an
ExponentialHistogram to an Explicit (_normal_) Histogram.

`ExplicitBounds` is represents the list of bucket boundaries for the new
histogram. This argument is __required__ and __cannot be empty__.

__WARNING:__

The process of converting an ExponentialHistogram to an Explicit
Histogram is not perfect and may result in a loss of precision. It is
important to define an appropriate set of bucket boundaries to minimize
this loss. For example, selecting Boundaries that are too high or too
low may result histogram buckets that are too wide or too narrow,
respectively.

---------

Co-authored-by: Kent Quirk <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flands @tigrannajaryan @MohamedElqdusy