Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] Add support for profiles signal #35980

Closed
mx-psi opened this issue Oct 24, 2024 · 2 comments · Fixed by #36107
Closed

[processor/resourcedetection] Add support for profiles signal #35980

mx-psi opened this issue Oct 24, 2024 · 2 comments · Fixed by #36107
Labels
data:profiles Profiles related issues help wanted Extra attention is needed priority:p2 Medium processor/resourcedetection Resource detection processor

Comments

@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2024

Component(s)

processor/resourcedetection

Describe the issue you're reporting

This processor would be useful for testing and validation of the experimental profiling signal, and to replace some functionality available in the eBPF Agent.

As inspiration for how to add support this PR can be used: open-telemetry/opentelemetry-collector/pull/11071 (there is no processor with support as of the writing of this issue)

Example of configuration using profiles (needs service.profilesSupport feature gate to be enabled):

receivers:
  otlp:
    protocols:
      grpc:
exporters:
  otlp:
    endpoint: ${OTLP_ENDPOINT}
service:
  pipelines:
    profiles:
      receivers: [otlp]
      exporters: [otlp]
@mx-psi mx-psi added help wanted Extra attention is needed priority:p2 Medium data:profiles Profiles related issues labels Oct 24, 2024
@github-actions github-actions bot added the processor/resourcedetection Resource detection processor label Oct 24, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@odubajDT
Copy link
Contributor

Hi, I would like to take a look at this issues, since a similar issue for attributesprocessor assigned to me is blocked by support for Profiles in pkg/ottl. This processor should not have any blocker.

@mx-psi mx-psi closed this as completed in 9ae4b5b Nov 7, 2024
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this issue Nov 7, 2024
…pen-telemetry#36107)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

- added support for Profiles signal in processor
- added tests
- adapted README
- performed `go mod tidy` on components which depend on the processor

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35980

---------

Signed-off-by: odubajDT <[email protected]>
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…pen-telemetry#36107)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

- added support for Profiles signal in processor
- added tests
- adapted README
- performed `go mod tidy` on components which depend on the processor

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#35980

---------

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:profiles Profiles related issues help wanted Extra attention is needed priority:p2 Medium processor/resourcedetection Resource detection processor
Projects
None yet
2 participants