Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor] use nop components during bootstrapping #32455

Closed
Tracked by #24327
evan-bradley opened this issue Apr 16, 2024 · 4 comments
Closed
Tracked by #24327

[cmd/opampsupervisor] use nop components during bootstrapping #32455

evan-bradley opened this issue Apr 16, 2024 · 4 comments
Assignees
Labels
cmd/opampsupervisor enhancement New feature or request good first issue Good for newcomers

Comments

@evan-bradley
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Is your feature request related to a problem? Please describe.

The OpAMP Supervisor needs to create a no-op pipeline to start the Collector with just the OpAMP extension during the bootstrapping process. Most existing components are not universally-present or have some issue (e.g. they bind to a port) that makes them non-ideal.

Describe the solution you'd like

The best components to use here are the nopexporter and noprecevier, which are lightweight, won't stop the Collector from starting, don't require special configuration, and should not be difficult to include in a distro. Switch the Supervisor's bootstrap config to use these components instead of the current components used in the no-op pipeline.

Describe alternatives you've considered

No response

Additional context

No response

@evan-bradley evan-bradley added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers cmd/opampsupervisor labels Apr 16, 2024
Copy link
Contributor

Pinging code owners for cmd/opampsupervisor: @evan-bradley @atoulme @tigrannajaryan. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmolenda-sumo
Copy link
Contributor

I will be happy to take care of this issue

@evan-bradley evan-bradley removed the help wanted Extra attention is needed label Apr 16, 2024
evan-bradley added a commit that referenced this issue Apr 23, 2024
**Description:** <Describe what has changed.>
Switch the Supervisor's bootstrap config to use nopreceiver and
nopexporter

**Link to tracking Issue:** #32455

---------

Co-authored-by: Evan Bradley <[email protected]>
@srikanthccv
Copy link
Member

this can be closed now?

@evan-bradley
Copy link
Contributor Author

Good catch, looks like the issue wasn't linked to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants