Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/httpforwarder] Remove deprecated use of host.ReportFatalError #30581

Closed
Tracked by #30501
atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #31134
Closed
Tracked by #30501

[extension/httpforwarder] Remove deprecated use of host.ReportFatalError #30581

atoulme opened this issue Jan 16, 2024 · 1 comment · Fixed by #31134
Labels
bug Something isn't working extension/httpforwarder

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 16, 2024 •
edited
Loading

Component(s)

extension/httpforwarder

Describe the issue you're reporting

Refactor to remove use of host.ReportFatalError, you can use settings.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err)) instead.

See #30505 for an example.
@atoulme atoulme added the needs triage New item requiring triage label Jan 16, 2024
@atoulme atoulme mentioned this issue Jan 16, 2024
Closed
21 tasks
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for extension/httpforwarder: @atoulme @rmfitzpatrick. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added bug Something isn't working and removed needs triage New item requiring triage labels Jan 16, 2024
@github-actions github-actions bot mentioned this issue Jan 23, 2024
Closed
@atoulme atoulme mentioned this issue Feb 8, 2024
Merged
mx-psi pushed a commit that referenced this issue Feb 8, 2024
@atoulme
[chore] Remove use of ReportFatalError from httpforwarder extension (#…
df12bfc 
…31134)

Fixes #30581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working extension/httpforwarder
Projects
None yet
Milestone
No milestone
2 participants
@atoulme @crobert-1