-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdatatest] Ignore span timestamps #27688
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Comments
atoulme
added
enhancement
New feature or request
needs triage
New item requiring triage
labels
Oct 16, 2023
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
djaglowski
added
help wanted
Extra attention is needed
good first issue
Good for newcomers
and removed
needs triage
New item requiring triage
labels
Oct 16, 2023
Hello @atoulme, could you kindly assign to me, thanks! |
dmitryax
pushed a commit
that referenced
this issue
Oct 17, 2023
**Description:** Support ignore timestamps in span comparisons for pdatatest. **Link to tracking Issue:** #27688 **Testing:** make chlog-validate go test for pkg/pdatatest **Documentation:** Add usage for `ptracetest.IgnoreStartTimestamp()` and `ptracetest.IgnoreEndTimestamp()`
Thanks @sakulali ! |
JaredTan95
pushed a commit
to openinsight-proj/opentelemetry-collector-contrib
that referenced
this issue
Oct 18, 2023
**Description:** Support ignore timestamps in span comparisons for pdatatest. **Link to tracking Issue:** open-telemetry#27688 **Testing:** make chlog-validate go test for pkg/pdatatest **Documentation:** Add usage for `ptracetest.IgnoreStartTimestamp()` and `ptracetest.IgnoreEndTimestamp()`
sigilioso
pushed a commit
to carlossscastro/opentelemetry-collector-contrib
that referenced
this issue
Oct 27, 2023
**Description:** Support ignore timestamps in span comparisons for pdatatest. **Link to tracking Issue:** open-telemetry#27688 **Testing:** make chlog-validate go test for pkg/pdatatest **Documentation:** Add usage for `ptracetest.IgnoreStartTimestamp()` and `ptracetest.IgnoreEndTimestamp()`
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this issue
Nov 12, 2023
**Description:** Support ignore timestamps in span comparisons for pdatatest. **Link to tracking Issue:** open-telemetry#27688 **Testing:** make chlog-validate go test for pkg/pdatatest **Documentation:** Add usage for `ptracetest.IgnoreStartTimestamp()` and `ptracetest.IgnoreEndTimestamp()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Component(s)
pkg/pdatatest
Is your feature request related to a problem? Please describe.
The pdatatest framework currently enforces span comparisons based on timestamps.
Describe the solution you'd like
I would like to be able to ignore timestamps in comparisons.
Describe alternatives you've considered
We use this code to modify the spans:
Additional context
No response
The text was updated successfully, but these errors were encountered: