Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/awscloudwatchlogs] invalid_num_consumers unit test failure #27624

Closed
crobert-1 opened this issue Oct 11, 2023 · 4 comments
Closed

[exporter/awscloudwatchlogs] invalid_num_consumers unit test failure #27624

crobert-1 opened this issue Oct 11, 2023 · 4 comments
Assignees
@bryan-aguilar
Labels
bug Something isn't working exporter/awscloudwatchlogs awscloudwatchlogs exporter priority:p2 Medium

Comments

@crobert-1
Copy link
Member

Component(s)

exporter/awscloudwatchlogs

What happened?

Description

CI/CD Test is failing

--- FAIL: TestLoadConfig (0.01s)
    --- FAIL: TestLoadConfig/awscloudwatchlogs/invalid_num_consumers (0.00s)
        config_test.go:102: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter/config_test.go:102
            	Error:      	Error "number of queue consumers must be positive; number of queue consumers must be positive" does not contain "'sending_queue.num_consumers' must be 1 or greater"
            	Test:       	TestLoadConfig/awscloudwatchlogs/invalid_num_consumers
FAIL
	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter	coverage: 88.5% of statements
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/awscloudwatchlogsexporter	0.076s

Failure link

Collector version

v0.87.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@crobert-1 crobert-1 added bug Something isn't working needs triage New item requiring triage labels Oct 11, 2023
@github-actions github-actions bot added the exporter/awscloudwatchlogs awscloudwatchlogs exporter label Oct 11, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23
Copy link
Member

songy23 commented Oct 11, 2023

#26692 looks related

@bryan-aguilar bryan-aguilar self-assigned this Oct 11, 2023
@bryan-aguilar bryan-aguilar added priority:p2 Medium and removed needs triage New item requiring triage labels Oct 11, 2023
@bryan-aguilar
Copy link
Contributor

Working on this now, PR should follow shortly.

@bryan-aguilar bryan-aguilar mentioned this issue Oct 11, 2023
Merged
mx-psi pushed a commit that referenced this issue Oct 11, 2023
@bryan-aguilar
[chore] [exporter/awscloudwatchlogs] Remove duplicate consumer check (#…
02cac2f 
…27625)

**Description:** v0.87.0 `exporterhelper.queue_settings.validate()`
verifies the consumer setting for us. We no longer need to duplicate
that validation.

**Link to tracking Issue:** <Issue number if applicable> #27624
@bryan-aguilar
Copy link
Contributor

fixed in #27625

@github-actions github-actions bot mentioned this issue Oct 17, 2023
Closed
JaredTan95 pushed a commit to openinsight-proj/opentelemetry-collector-contrib that referenced this issue Oct 18, 2023
@bryan-aguilar @JaredTan95
[chore] [exporter/awscloudwatchlogs] Remove duplicate consumer check (o…
bf5ce0d 
…pen-telemetry#27625)

**Description:** v0.87.0 `exporterhelper.queue_settings.validate()`
verifies the consumer setting for us. We no longer need to duplicate
that validation.

**Link to tracking Issue:** <Issue number if applicable> open-telemetry#27624
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@bryan-aguilar @jmsnll
[chore] [exporter/awscloudwatchlogs] Remove duplicate consumer check (o…
042658f 
…pen-telemetry#27625)

**Description:** v0.87.0 `exporterhelper.queue_settings.validate()`
verifies the consumer setting for us. We no longer need to duplicate
that validation.

**Link to tracking Issue:** <Issue number if applicable> open-telemetry#27624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryan-aguilar bryan-aguilar

Labels
bug Something isn't working exporter/awscloudwatchlogs awscloudwatchlogs exporter priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@songy23 @bryan-aguilar @crobert-1