Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI is broken on main #27245

Closed
mx-psi opened this issue Sep 27, 2023 · 1 comment · Fixed by #27246
Closed

CI is broken on main #27245

mx-psi opened this issue Sep 27, 2023 · 1 comment · Fixed by #27246
Labels
priority:p1 High processor/tailsampling Tail sampling processor release:blocker The issue must be resolved before cutting the next release

Comments

@mx-psi
Copy link
Member

mx-psi commented Sep 27, 2023 

          This broke main

Error: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/processor/tailsamplingprocessor/metrics.go:93:16: undefined: obsreport

@jmsnll @jpkrohling would you be able to do a quick fix? Or should I revert the PR and we can address this more calmly?

Originally posted by @mx-psi in #26724 (comment)
@mx-psi mx-psi added priority:p1 High processor/tailsampling Tail sampling processor release:blocker The issue must be resolved before cutting the next release labels Sep 27, 2023
@github-actions
Copy link
Contributor

Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten codeboten mentioned this issue Sep 27, 2023
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Sep 27, 2023
[chore] fix reference to obsreport
aa8cef9 
This was missed in a previous merge. Fixes open-telemetry#27245

Signed-off-by: Alex Boten <[email protected]>
codeboten pushed a commit that referenced this issue Sep 27, 2023
[chore] fix reference to obsreport (#27246)
0158c5f 
This was missed in a previous merge. Fixes #27245

Signed-off-by: Alex Boten <[email protected]>
This was referenced Oct 3, 2023
Closed
Open
jmsnll pushed a commit to jmsnll/opentelemetry-collector-contrib that referenced this issue Nov 12, 2023
@jmsnll
[chore] fix reference to obsreport (open-telemetry#27246)
6bbfcfb 
This was missed in a previous merge. Fixes open-telemetry#27245

Signed-off-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High processor/tailsampling Tail sampling processor release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] fix reference to obsreport codeboten/opentelemetry-collector-contrib
1 participant
@mx-psi