Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/spanmetrics] clarification around README.md #26520

Closed
karmingc opened this issue Sep 7, 2023 · 6 comments
Closed

[connector/spanmetrics] clarification around README.md #26520

karmingc opened this issue Sep 7, 2023 · 6 comments
Assignees
@karmingc
Labels
closed as inactive connector/spanmetrics documentation Improvements or additions to documentation Stale

Comments

@karmingc
Copy link
Contributor

karmingc commented Sep 7, 2023

Component(s)

connector/spanmetrics

Describe the issue you're reporting

I believe the README.md could specify that the metrics generated are the following:

  • calls
  • duration

Though, I'm not too sure if the "error" metric is indeed generated as the README.md suggests, maybe I missed something in the code?
@karmingc karmingc added the needs triage New item requiring triage label Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added the documentation Improvements or additions to documentation label Sep 7, 2023
@albertteoh
Copy link
Contributor

I like your suggestion to clearly state what metrics the spanmetrics connector generates, @karmingc.

There's indeed no error metric generated, and is, instead derivable from a status_code=STATUS_CODE_ERROR dimension.

Would you like to make a contribution to the README?

@karmingc
Copy link
Contributor Author

karmingc commented Sep 8, 2023

I like your suggestion to clearly state what metrics the spanmetrics connector generates, @karmingc.

There's indeed no error metric generated, and is, instead derivable from a status_code=STATUS_CODE_ERROR dimension.

Would you like to make a contribution to the README?

Sounds good, thanks for clarifying as well! I'll ping you for a review once it's up.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Sep 8, 2023
@crobert-1
Copy link
Member

Assigning to @karmingc, let me know if that's incorrect!

@github-actions github-actions bot mentioned this issue Sep 12, 2023
Open
This was referenced Sep 12, 2023
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 8, 2023
@karmingc karmingc mentioned this issue Nov 12, 2023
Merged
jpkrohling pushed a commit that referenced this issue Nov 23, 2023
@karmingc
[connector/spanmetrics] fix(docs): add example of R.E.D metrics for s…
accfdcc 
…pan data (#29115)

**Description:** This is to clarify the metrics name generated.

**Link to tracking Issue:**
[26520](#26520)

**Testing:** n/a docs

**Documentation:** n/a
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@karmingc @RoryCrispin
[connector/spanmetrics] fix(docs): add example of R.E.D metrics for s…
c1a365e 
…pan data (open-telemetry#29115)

**Description:** This is to clarify the metrics name generated.

**Link to tracking Issue:**
[26520](open-telemetry#26520)

**Testing:** n/a docs

**Documentation:** n/a
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmingc karmingc

Labels
closed as inactive connector/spanmetrics documentation Improvements or additions to documentation Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albertteoh @karmingc @crobert-1