Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port deprecated servicegraph processor code to servicegraph connector #26091

Closed
rlankfo opened this issue Aug 24, 2023 · 3 comments · Fixed by #30149
Closed

port deprecated servicegraph processor code to servicegraph connector #26091

rlankfo opened this issue Aug 24, 2023 · 3 comments · Fixed by #30149
Labels
closed as inactive connector/servicegraph enhancement New feature or request Stale

Comments

@rlankfo
Copy link
Member

rlankfo commented Aug 24, 2023 •
edited
Loading

Component(s)

connector/servicegraph

Describe the issue you're reporting

The servicegraphprocessor was deprecated in favor of the servicegraphconnector. See #23996.

The connector is a thin wrapper around the processor at this point. I propose that we migrate this code and remove code paths required for this component to operate as a processor.
@rlankfo rlankfo added the needs triage New item requiring triage label Aug 24, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rlankfo rlankfo changed the title port deprecated servicegraphprocessor code to servicegraphconnector port deprecated servicegraph processor code to servicegraph connector Aug 24, 2023
@rlankfo rlankfo mentioned this issue Aug 24, 2023
Closed
@jpkrohling jpkrohling added enhancement New feature or request and removed needs triage New item requiring triage labels Aug 24, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 24, 2023
@codeboten codeboten mentioned this issue Dec 20, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Feb 1, 2024
[processor/servicegraph] remove deprecated component
ab64a47 
This component was replaced by the servicegraphconnector, which was a wrapper around the servicegraphprocessor. This PR moves the processor code into the connector component and removes the processor altogether. Note that as part of this PR I added the traces_to_traces support as it was supported by the processor before (with the development status).

Fixes open-telemetry#30041
Fixes open-telemetry#26091

Signed-off-by: Alex Boten <[email protected]>
codeboten pushed a commit that referenced this issue Feb 2, 2024
[processor/servicegraph] remove deprecated component (#30149)
d02d376 
This component was replaced by the servicegraphconnector, which was a
wrapper around the servicegraphprocessor. This PR moves the processor
code into the connector component and removes the processor altogether.
Note that as part of this PR I added the traces_to_traces support as it
was supported by the processor before (with the development status).

Fixes #30041
Fixes #26091

---------

Signed-off-by: Alex Boten <[email protected]>
@rlankfo rlankfo mentioned this issue Feb 7, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed as inactive connector/servicegraph enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[processor/servicegraph] remove deprecated component codeboten/opentelemetry-collector-contrib
2 participants
@jpkrohling @rlankfo