Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws s3 exporter - support custom endpoint configuration #21833

Closed
guyfrid opened this issue May 11, 2023 · 5 comments
Closed

aws s3 exporter - support custom endpoint configuration #21833

guyfrid opened this issue May 11, 2023 · 5 comments
Assignees
@guyfrid
Labels
enhancement New feature or request exporter/awss3 Stale

Comments

@guyfrid
Copy link
Contributor

guyfrid commented May 11, 2023

Component(s)

exporter/awss3

Is your feature request related to a problem? Please describe.

The exporter configuration lacks support for configuring the S3 endpoint, which can be inconvenient during local development. Adding the ability to configure the S3 endpoint would enhance flexibility and ease of use in different environments.

Describe the solution you'd like

The configuration for the AWS S3 exporter includes support for specifying a custom endpoint. The endpoint parameter is optional and can be provided during session creation if needed. If the endpoint parameter is not provided, the exporter will fallback to using the default value specified in the AWS_ENDPOINT_URL environment variable. This allows flexibility in defining the endpoint for the exporter, enabling seamless integration with different AWS S3 service configurations.

Describe alternatives you've considered

No response

Additional context

No response
@guyfrid guyfrid added enhancement New feature or request needs triage New item requiring triage labels May 11, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@guyfrid
Copy link
Contributor Author

guyfrid commented May 11, 2023

I want to work on this feature. please assign it to me

@atoulme atoulme removed the needs triage New item requiring triage label May 11, 2023
@atoulme
Copy link
Contributor

atoulme commented May 11, 2023

It's yours @guyfrid !

@guyfrid guyfrid mentioned this issue May 15, 2023
Merged
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 11, 2023
mx-psi added a commit that referenced this issue Aug 1, 2023
@guyfrid @atoulme @mx-psi
Support configure aws endpoint url (#21917)
475ce03 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
The AWS S3 exporter configuration currently doesn't allow customization
of the S3 endpoint, which can be troublesome during local development.
To improve flexibility, the exporter now supports specifying a custom
endpoint during session creation.

**Link to tracking Issue:** <Issue number if applicable>

#21833

**Testing:** <Describe what testing was performed and which tests were
added.>
- UT with endpoint configured

**Documentation:** <Describe the documentation added.>
update README  with the new field

---------

Signed-off-by: guyfried <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
@guyfrid guyfrid closed this as completed Aug 22, 2023
@cwegener
Copy link
Contributor

cwegener commented Sep 4, 2023

This is very useful indeed. Thanks for implementing this.

I wonder if S3ForcePathStyle would also be needed in addition to the endpoint in order to use a single label hostname in the URL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guyfrid guyfrid

Labels
enhancement New feature or request exporter/awss3 Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@atoulme @cwegener @guyfrid