-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle receiver start errors in receiver_creator at runtime #178
Comments
When the grpc-gateway was added to this receiver/opencensus Trace receiver in OpenCensus-Service PR census-instrumentation/opencensus-service#270, we recognized that browsers and other sources that send JSON in one burst won't stream so would encounter an io.EOF. This PR makes the metrics receiver replicate that behavior. Fixes #178
* rename package tag to package distributedContext * rename Tag -> Entry * change distributed context -> dctx to avoid capitalization collision * change dctx -> distributedcontext * update stackdriver client example
* Update changelog ahead of 0.19.0 release
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This issue has been closed as inactive because it has been stale for 120 days with no activity. |
It's currently unclear how to appropriately handle start errors for receivers started in receiver_creator. This includes errors returned by
Start()
as well as errors reported throughReportFatalError
. The existing methods are built around the assumption that start errors always occur at process start or shortly thereafter.See discussion in #173 (comment)
The text was updated successfully, but these errors were encountered: