Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle receiver start errors in receiver_creator at runtime #178

Closed
jrcamp opened this issue Apr 17, 2020 · 2 comments
Closed

How to handle receiver start errors in receiver_creator at runtime #178

jrcamp opened this issue Apr 17, 2020 · 2 comments

Comments

@jrcamp
Copy link
Contributor

jrcamp commented Apr 17, 2020

It's currently unclear how to appropriately handle start errors for receivers started in receiver_creator. This includes errors returned by Start() as well as errors reported through ReportFatalError. The existing methods are built around the assumption that start errors always occur at process start or shortly thereafter.

See discussion in #173 (comment)

mxiamxia referenced this issue in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
When the grpc-gateway was added to this receiver/opencensus
Trace receiver in OpenCensus-Service PR
census-instrumentation/opencensus-service#270,
we recognized that browsers and other sources that send JSON
in one burst won't stream so would encounter an io.EOF.
This PR makes the metrics receiver replicate that behavior.

Fixes #178
@tigrannajaryan tigrannajaryan added this to the Backlog milestone Jul 30, 2020
@alolita alolita added the comp: receiver Receiver label Sep 30, 2021
ljmsc referenced this issue in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* rename package tag to package distributedContext

* rename Tag -> Entry

* change distributed context -> dctx to avoid capitalization collision

* change dctx -> distributedcontext

* update stackdriver client example
bogdandrutu pushed a commit that referenced this issue May 12, 2022
* Update changelog ahead of 0.19.0 release
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2023
bjrara pushed a commit to bjrara/opentelemetry-collector-contrib that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants