-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Data Explorer Exporter time formatting #16546
Comments
/label exporter/azuredataexplorer |
Looks like the new issue workflow failed so pinging code owners manually. Hey @asaharan, @ag-ramachandran 👋 |
@tmeadon looking into this. Will replicate and provide a fix for this |
Awesome! Thanks @ag-ramachandran 👍 What needs to happen following a merge to the main repo before I can consume these changes? |
That is right, we will raise the PR to the main repo later today or worst case tomorrow. Once it gets into the main branch it should be good in the next build |
…sion (#3583) * *Fixes issue #16546 adding support for timestamp in Nano second precision * * Add changelog, amend testcases * * azure-kusto-go version update Co-authored-by: Abhishek Saharn <[email protected]>
Thanks for looking at this so quickly @ag-ramachandran! |
1. The current timestamp used in the collector is RFC3339, this causes truncation and makes it hard when much more granular precision of time is needed. This is changed to RFC3339Nano 2. Updates underlying SDK to interact with the database Co-authored-by: Abhishek Saharn <[email protected]>
…try#16568) 1. The current timestamp used in the collector is RFC3339, this causes truncation and makes it hard when much more granular precision of time is needed. This is changed to RFC3339Nano 2. Updates underlying SDK to interact with the database Co-authored-by: Abhishek Saharn <[email protected]>
Hello @tmeadon, Since the PR is merged the latest build should have this fix on the distribution. Would you be able to give this a try and close the issue if the fix looks fine. |
Perfect! Thanks again @ag-ramachandran 😀 |
Component(s)
exporter/azuredataexplorer
Describe the issue you're reporting
Due to the use of
RFC3339
formatting in the ADX exporter, timestamps in spans, metrics, and logs do not include milliseconds or nanoseconds, despite this level of precision being present in the telemetry emitted by the SDK (.NET in my case). This makes it impossible to sort spans in a given trace when they all complete within the same second - they appear to all happen simultaneously.The text was updated successfully, but these errors were encountered: