Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheusreceiver] Use _created to set StartTimeUnixNano #12428

Closed
gouthamve opened this issue Jul 14, 2022 · 6 comments · Fixed by #17498
Closed

[prometheusreceiver] Use _created to set StartTimeUnixNano #12428

gouthamve opened this issue Jul 14, 2022 · 6 comments · Fixed by #17498
Labels
bug Something isn't working never stale Issues marked with this label will be never staled and automatically removed priority:p1 High receiver/prometheus Prometheus receiver

Comments

@gouthamve
Copy link
Member

Currently we're using MetricsAdjuster to set the StartTimeUnixNano for the metrics. But when {name}_created is available we should use that.

See: #12426

@gouthamve gouthamve added the bug Something isn't working label Jul 14, 2022
@TylerHelmuth TylerHelmuth added the receiver/prometheus Prometheus receiver label Jul 15, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @dmitryax

@TylerHelmuth TylerHelmuth removed the receiver/prometheus Prometheus receiver label Jul 15, 2022
@TylerHelmuth
Copy link
Member

pinging @Aneurysm9 @dashpole as code owners

@TylerHelmuth TylerHelmuth added the priority:needed Triagers reviewed the issue but need code owner to set priority label Jul 15, 2022
@dashpole dashpole added the receiver/prometheus Prometheus receiver label Jul 18, 2022
@dashpole
Copy link
Contributor

We will also need to make some changes to the prom specification to support this:

  • Prometheus exporters (including language + collector) SHOULD produce _created series for cumulative types, but this can be turned off.
  • The prometheus receiver MUST drop the _created series, if present, and use it to set the start timestamp.

@dashpole
Copy link
Contributor

I just noticed open-telemetry/opentelemetry-specification#2645, so no spec change is needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 9, 2022
@dashpole dashpole added priority:p1 High and removed Stale priority:needed Triagers reviewed the issue but need code owner to set priority labels Nov 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 9, 2023
@gouthamve gouthamve added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jan 9, 2023
codeboten pushed a commit that referenced this issue Jan 12, 2023
…et StartTimeUnixNano on Sum, Histogram, Summaries (#17498)

Use _created metric, if present, to set StartTimeUnixNano on Sum, Histogram, Summary metrics.
Resolves #12428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale Issues marked with this label will be never staled and automatically removed priority:p1 High receiver/prometheus Prometheus receiver
Projects
None yet
3 participants