-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: Solace Receiver #10572
Comments
@open-telemetry/collector-contrib-approvers, is there anyone very familiar with traces who would like to sponsor this? Otherwise, I will take it as my round robin assignment. |
I'll sponsor this. (Also, I won't make it to the SIG meeting tomorrow, so I will remove the agenda item. Feel free to readd if you have more to address at the SIG.) |
As part of our component, we unmarshal data into a protobuf generated model currently generated with |
@bogdandrutu, do you mind weighing in on this? |
* Added Solace Receiver * Added entry to codeowners for Solace receiver * Fixed linting errors Use uber's atomic package, use errors.Is instead of equality * Bumped dependency versions * Added solacereceiver to dependabot workflow * Added solacereceiver to CHANGELOG.md * Ran make gotidy * Refactored pdata package into model package * Restructured config moving transport.tls.* to tls.* * Updated Solace receiver to v0.55.0 of collector libraries * Make gotidy with proper version of collector dependencies * Updated protobuf spec to include service version, remove AD enqueue A few other fields are also added and tests adjusted accordingly Addresses SOL-73532, SOL-73533, SOL-73534 * Followed new changelog process to add a new component entry
Hi @mcardy 👋 If it is very similar, maybe we could talk about making it a bit more general and not vendor-specific so we will have a general AMQP Receiver? In my situation for example, I need a receiver to read from RabbitMQ... But I guess it will be great for more solutions using AMQP 😎 |
Hi @adirmatzkin, Unfortunately I don't think the Solace receiver can serve the same purpose of 10592. The AMQP transport is only a portion of the puzzle. Any AMQP receiver based component needs to map the incoming message data to OpenTelemetry models as well as report relevant stats and make decisions around upgrade scenarios. This accounts for the majority of the code within the Solace Receiver component and this is not generalizable. Also, Azure AMQP is an AMQP v1.0 client whereas RabbitMQ AMQP is v0.9.1. Despite the similar name these are completely different specs. |
The purpose and use-cases of the new component
The Solace Receiver would collect traces from a Solace PubSub+ Event Broker using Azure AMQP Golang client API. This component would provide message tracing capabilities for a Solace PubSub+ Event Broker. It will enable full end to end message lifecycle tracing exportable to backends such as Jaeger, Zipkin or Datadog for visualization.
Solace is currently actively working on a next generation OpenTelemetry tracing integration into the event broker. The release of this component will be coordinated with community to align with a public availability of a Solace event messaging broker with tracing support.
The Solace Receiver will receive trace messages as Guaranteed Messages from a Solace PubSub+ event broker and produce trace spans for the OpenTelemetry Collector.
Example configuration for the component
The configuration parameters are:
queue://#telemetry-myTelemetryProfile
)Examples:
Simple single node configuration with SASL plain text authentication (and tls enabled by default)
High availability setup with SASL plain text authentication (and tls enabled by default)
Telemetry data types supported
Trace
Sponsor (Optional)
No sponsor as of now
The text was updated successfully, but these errors were encountered: