Skip to content

Commit

Permalink
[chore] remove unnecessary allocations in fluentforwardreceiver
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <[email protected]>
  • Loading branch information
bogdandrutu committed Sep 28, 2022
1 parent e227180 commit db6f7e4
Showing 1 changed file with 12 additions and 19 deletions.
31 changes: 12 additions & 19 deletions receiver/fluentforwardreceiver/collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -53,35 +53,28 @@ func (c *Collector) processEvents(ctx context.Context) {
case <-ctx.Done():
return
case e := <-c.eventCh:
buffered := []Event{e}
out := plog.NewLogs()
rls := out.ResourceLogs().AppendEmpty()
logSlice := rls.ScopeLogs().AppendEmpty().LogRecords()
e.LogRecords().MoveAndAppendTo(logSlice)

// Pull out anything waiting on the eventCh to get better
// efficiency on LogResource allocations.
buffered = fillBufferUntilChanEmpty(c.eventCh, buffered)
c.fillBufferUntilChanEmpty(logSlice)

logs := collectLogRecords(buffered)
_ = c.nextConsumer.ConsumeLogs(ctx, logs)
stats.Record(context.Background(), observ.RecordsGenerated.M(int64(out.LogRecordCount())))
_ = c.nextConsumer.ConsumeLogs(ctx, out)
}
}
}

func fillBufferUntilChanEmpty(eventCh <-chan Event, buf []Event) []Event {
func (c *Collector) fillBufferUntilChanEmpty(dest plog.LogRecordSlice) {
for {
select {
case e2 := <-eventCh:
buf = append(buf, e2)
case e := <-c.eventCh:
e.LogRecords().MoveAndAppendTo(dest)
default:
return buf
return
}
}
}

func collectLogRecords(events []Event) plog.Logs {
out := plog.NewLogs()
rls := out.ResourceLogs().AppendEmpty()
logSlice := rls.ScopeLogs().AppendEmpty().LogRecords()
for i := range events {
events[i].LogRecords().MoveAndAppendTo(logSlice)
}
stats.Record(context.Background(), observ.RecordsGenerated.M(int64(out.LogRecordCount())))
return out
}

0 comments on commit db6f7e4

Please sign in to comment.