[receiver/mongodb] Enable linter and fix issues (#11798)

open-telemetry · Jun 29, 2022 · ce857ae · ce857ae
1 parent 7871997
commit ce857ae
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/receiver/mongodbreceiver/client_test.go b/receiver/mongodbreceiver/client_test.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:gocritic
 package mongodbreceiver // import "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/mongodbreceiver"
 
 import (
@@ -54,13 +53,13 @@ func (fc *fakeClient) GetVersion(ctx context.Context) (*version.Version, error)
 	return args.Get(0).(*version.Version), args.Error(1)
 }
 
-func (fc *fakeClient) ServerStatus(ctx context.Context, DBName string) (bson.M, error) {
-	args := fc.Called(ctx, DBName)
+func (fc *fakeClient) ServerStatus(ctx context.Context, dbName string) (bson.M, error) {
+	args := fc.Called(ctx, dbName)
 	return args.Get(0).(bson.M), args.Error(1)
 }
 
-func (fc *fakeClient) DBStats(ctx context.Context, DBName string) (bson.M, error) {
-	args := fc.Called(ctx, DBName)
+func (fc *fakeClient) DBStats(ctx context.Context, dbName string) (bson.M, error) {
+	args := fc.Called(ctx, dbName)
 	return args.Get(0).(bson.M), args.Error(1)
 }
 

diff --git a/receiver/mongodbreceiver/scraper_test.go b/receiver/mongodbreceiver/scraper_test.go
@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:errcheck
 package mongodbreceiver
 
 import (
@@ -90,7 +89,7 @@ func TestScrape(t *testing.T) {
 	expectedMetrics, err := golden.ReadMetrics(expectedFile)
 	require.NoError(t, err)
 
-	scrapertest.CompareMetrics(actualMetrics, expectedMetrics)
+	require.NoError(t, scrapertest.CompareMetrics(actualMetrics, expectedMetrics))
 }
 
 func TestScrapeNoClient(t *testing.T) {

diff --git a/receiver/mongodbreceiver/testdata/scraper/expected.json b/receiver/mongodbreceiver/testdata/scraper/expected.json
@@ -5,7 +5,7 @@
             "scopeMetrics": [
                 {
                     "scope": {
-                        "name": "otelcol/mongodb",
+                        "name": "otelcol/mongodbreceiver",
                         "version": "latest"
                     },
                     "metrics": [
@@ -169,7 +169,7 @@
             "scopeMetrics": [
                 {
                     "scope": {
-                        "name": "otelcol/mongodb",
+                        "name": "otelcol/mongodbreceiver",
                         "version": "latest"
                     },
                     "metrics": [