feat[solace-receiver]: removed support for the messaging.destination.…

…anonymous attribute
open-telemetry · Jun 10, 2024 · 9bc905f · 9bc905f
1 parent dffd65b
commit 9bc905f
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 12 deletions.
diff --git a/receiver/solacereceiver/unmarshaller.go b/receiver/solacereceiver/unmarshaller.go
@@ -120,7 +120,6 @@ const (
 	messageBodySizeBytesAttrKey        = "messaging.message.body.size"
 	messageEnvelopeSizeBytesAttrKey    = "messaging.message.envelope.size"
 	destinationNameAttrKey             = "messaging.destination.name"
-	isUnknownAnonymousDistinationKey   = "messaging.destination.anonymous"
 	clientUsernameAttrKey              = "messaging.solace.client_username"
 	clientNameAttrKey                  = "messaging.solace.client_name"
 	replicationGroupMessageIDAttrKey   = "messaging.solace.replication_group_message_id"

diff --git a/receiver/solacereceiver/unmarshaller_receive.go b/receiver/solacereceiver/unmarshaller_receive.go
@@ -133,13 +133,6 @@ func (u *brokerTraceReceiveUnmarshallerV1) mapClientSpanAttributes(spanData *rec
 	attrMap.PutInt(receiveTimeAttrKey, spanData.BrokerReceiveTimeUnixNano)
 	attrMap.PutStr(destinationNameAttrKey, spanData.Topic)
 
-	// destination was to an anonymous/unknown queue/topic
-	var unknownAnonymousDistinationValue bool = false
-	if isAnonymousTopicEndpoint(spanData.Topic) {
-		unknownAnonymousDistinationValue = true
-	}
-	attrMap.PutBool(isUnknownAnonymousDistinationKey, unknownAnonymousDistinationValue)
-
 	var deliveryMode string
 	switch spanData.DeliveryMode {
 	case receive_v1.SpanData_DIRECT:

diff --git a/receiver/solacereceiver/unmarshaller_receive_test.go b/receiver/solacereceiver/unmarshaller_receive_test.go
@@ -194,7 +194,6 @@ func TestReceiveUnmarshallerMapClientSpanAttributes(t *testing.T) {
 				"messaging.message.body.size":                             int64(1200),          // payload (binary + xml attachments)
 				"messaging.message.envelope.size":                         int64(1234),          // payload with metadata
 				"messaging.destination.name":                              "someTopic",
-				"messaging.destination.anonymous":                         false,
 				"messaging.solace.client_username":                        "someClientUsername",
 				"messaging.solace.client_name":                            "someClient1234",
 				"messaging.solace.replication_group_message_id":           "rmid1:00010-40910192431-40516479-90a9c4e1",
@@ -250,7 +249,6 @@ func TestReceiveUnmarshallerMapClientSpanAttributes(t *testing.T) {
 				"messaging.message.body.size":                             int64(1200), // payload (binary + xml attachments)
 				"messaging.message.envelope.size":                         int64(1234), // payload with metadata
 				"messaging.destination.name":                              "someTopic",
-				"messaging.destination.anonymous":                         false,
 				"messaging.solace.client_username":                        "someClientUsername",
 				"messaging.solace.client_name":                            "someClient1234",
 				"messaging.solace.dmq_eligible":                           true,
@@ -297,7 +295,6 @@ func TestReceiveUnmarshallerMapClientSpanAttributes(t *testing.T) {
 				"messaging.message.body.size":                             int64(1200), // payload (binary + xml attachments)
 				"messaging.message.envelope.size":                         int64(1234), // payload with metadata
 				"messaging.destination.name":                              "someTopic",
-				"messaging.destination.anonymous":                         false,
 				"messaging.solace.client_username":                        "someClientUsername",
 				"messaging.solace.client_name":                            "someClient1234",
 				"messaging.solace.dmq_eligible":                           true,

diff --git a/receiver/solacereceiver/unmarshaller_test.go b/receiver/solacereceiver/unmarshaller_test.go
@@ -231,7 +231,6 @@ func TestSolaceMessageUnmarshallerUnmarshal(t *testing.T) {
 					"messaging.message.body.size":                             int64(1200),          // payload (binary + xml attachments)
 					"messaging.message.envelope.size":                         int64(1234),          // payload with metadata
 					"messaging.destination.name":                              "someTopic",
-					"messaging.destination.anonymous":                         false,
 					"messaging.solace.client_username":                        "someClientUsername",
 					"messaging.solace.client_name":                            "someClient1234",
 					"messaging.solace.replication_group_message_id":           "rmid1:00010-40910192431-40516479-90a9c4e1",