Skip to content

Commit

Permalink
[receiver/hostmetrics] Remove deprecated label from network metrics
Browse files Browse the repository at this point in the history
The label was missed to be removed once the metrics splitting was rolled back
  • Loading branch information
dmitryax committed Nov 9, 2022
1 parent e3fccb7 commit 64d2cc9
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 12 deletions.
6 changes: 6 additions & 0 deletions .chloggen/hostmetrics-remove-deprecated-label.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
change_type: bug_fix
component: receiver/hostmetrics
note: Remove "Deprecated" label from network metrics
issues: [16227]
subtext: |
Replacement of the metrics was rejected some time ago, but the labels were not updated.
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ These are the metrics available for this scraper.
| **system.network.connections** | The number of connections. | {connections} | Sum(Int) | <ul> <li>protocol</li> <li>state</li> </ul> |
| system.network.conntrack.count | The count of entries in conntrack table. | {entries} | Sum(Int) | <ul> </ul> |
| system.network.conntrack.max | The limit for entries in the conntrack table. | {entries} | Sum(Int) | <ul> </ul> |
| **system.network.dropped** | The number of packets dropped. (Deprecated) | {packets} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.errors** | The number of errors encountered. (Deprecated) | {errors} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.io** | The number of bytes transmitted and received. (Deprecated) | By | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.packets** | The number of packets transferred. (Deprecated) | {packets} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.dropped** | The number of packets dropped. | {packets} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.errors** | The number of errors encountered. | {errors} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.io** | The number of bytes transmitted and received. | By | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |
| **system.network.packets** | The number of packets transferred. | {packets} | Sum(Int) | <ul> <li>device</li> <li>direction</li> </ul> |

**Highlighted metrics** are emitted by default. Other metrics are optional and not emitted by default.
Any metric can be enabled or disabled with the following scraper configuration:
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ attributes:
metrics:
system.network.packets:
enabled: true
description: The number of packets transferred. (Deprecated)
description: The number of packets transferred.
unit: "{packets}"
sum:
value_type: int
Expand All @@ -26,7 +26,7 @@ metrics:
attributes: [device, direction]
system.network.dropped:
enabled: true
description: The number of packets dropped. (Deprecated)
description: The number of packets dropped.
unit: "{packets}"
sum:
value_type: int
Expand All @@ -35,7 +35,7 @@ metrics:
attributes: [device, direction]
system.network.errors:
enabled: true
description: The number of errors encountered. (Deprecated)
description: The number of errors encountered.
unit: "{errors}"
sum:
value_type: int
Expand All @@ -44,7 +44,7 @@ metrics:
attributes: [device, direction]
system.network.io:
enabled: true
description: The number of bytes transmitted and received. (Deprecated)
description: The number of bytes transmitted and received.
unit: "By"
sum:
value_type: int
Expand Down

0 comments on commit 64d2cc9

Please sign in to comment.